From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Alistair Francis <Alistair.Francis@wdc.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"alistair23@gmail.com" <alistair23@gmail.com>,
"riku.voipio@iki.fi" <riku.voipio@iki.fi>,
"laurent@vivier.eu" <laurent@vivier.eu>,
"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning
Date: Wed, 1 May 2019 17:21:21 +0200 [thread overview]
Message-ID: <9abcc3db-0749-e092-ab59-8144de027ba6@redhat.com> (raw)
In-Reply-To: <0d585793-20a8-8dc8-98fa-13789113f672@linaro.org>
On 5/1/19 4:12 PM, Richard Henderson wrote:
> On 4/30/19 4:28 PM, Alistair Francis wrote:
>> for (i = 0; i < usbports; i++) {
>> + g_assert(i < MAX(MAXPORTS_2, MAXPORTS_3));
>
> I would hope that it works to move this out of the loop:
>
> g_assert(usbports <= MAX(MAXPORTS_2, MAXPORTS_3));
With Richard suggestion:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-05-01 15:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 23:28 [Qemu-devel] [PATCH v2 0/5] Fix some GCC 9 build warnings Alistair Francis
2019-04-30 23:28 ` Alistair Francis
2019-04-30 23:28 ` [Qemu-devel] [PATCH v2 1/5] util/qemu-sockets: Fix " Alistair Francis
2019-04-30 23:28 ` Alistair Francis
2019-05-01 9:35 ` Laurent Vivier
2019-05-01 9:35 ` Laurent Vivier
2019-05-01 9:41 ` Daniel P. Berrangé
2019-05-01 9:41 ` Daniel P. Berrangé
2019-05-02 17:57 ` Alistair Francis
2019-05-02 17:57 ` Alistair Francis
2019-04-30 23:28 ` [Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning Alistair Francis
2019-04-30 23:28 ` Alistair Francis
2019-05-01 9:37 ` Laurent Vivier
2019-05-01 9:37 ` Laurent Vivier
2019-05-01 9:43 ` Daniel P. Berrangé
2019-05-01 9:43 ` Daniel P. Berrangé
2019-05-01 14:12 ` Richard Henderson
2019-05-01 14:12 ` Richard Henderson
2019-05-01 15:21 ` Philippe Mathieu-Daudé [this message]
2019-05-01 15:21 ` Philippe Mathieu-Daudé
2019-05-02 17:53 ` Alistair Francis
2019-05-02 17:53 ` Alistair Francis
2019-04-30 23:28 ` [Qemu-devel] [PATCH v2 3/5] hw/usb/dev-mtp: " Alistair Francis
2019-04-30 23:28 ` Alistair Francis
2019-05-01 7:12 ` Thomas Huth
2019-05-01 7:12 ` Thomas Huth
2019-05-01 9:40 ` Daniel P. Berrangé
2019-05-01 9:40 ` Daniel P. Berrangé
2019-05-02 17:48 ` Alistair Francis
2019-05-02 17:48 ` Alistair Francis
2019-04-30 23:28 ` [Qemu-devel] [PATCH v2 4/5] linux-user/uname: Fix GCC 9 build warnings Alistair Francis
2019-04-30 23:28 ` Alistair Francis
2019-05-01 9:40 ` Laurent Vivier
2019-05-01 9:40 ` Laurent Vivier
2019-05-01 9:44 ` Daniel P. Berrangé
2019-05-01 9:44 ` Daniel P. Berrangé
2019-05-01 9:46 ` Laurent Vivier
2019-05-01 9:46 ` Laurent Vivier
2019-05-01 12:00 ` Eric Blake
2019-05-01 12:00 ` Eric Blake
2019-05-02 17:24 ` Alistair Francis
2019-05-02 17:24 ` Alistair Francis
2019-04-30 23:29 ` [Qemu-devel] [PATCH v2 5/5] linux-user/elfload: " Alistair Francis
2019-04-30 23:29 ` Alistair Francis
2019-05-01 9:40 ` Laurent Vivier
2019-05-01 9:40 ` Laurent Vivier
2019-05-01 14:15 ` Richard Henderson
2019-05-01 14:15 ` Richard Henderson
2019-05-02 8:14 ` Laurent Vivier
2019-05-02 8:14 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9abcc3db-0749-e092-ab59-8144de027ba6@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).