From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Erik Skultety <eskultet@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qapi: add query-display-options command
Date: Tue, 20 Nov 2018 10:00:11 -0600 [thread overview]
Message-ID: <9abccebe-4bff-bc35-4fe2-fedbf23314fe@redhat.com> (raw)
In-Reply-To: <20181120085603.31472-1-kraxel@redhat.com>
On 11/20/18 2:56 AM, Gerd Hoffmann wrote:
> Add query-display-options command, which allows to query the qemu
s/allows to query/allows querying/
> display configuration, and -- as intentional side effect -- makes
s/as/as an/
> DisplayOptions discoverable via query-qmp-schema so libvirt can go
> figure which display options are supported.
>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Erik Skultety <eskultet@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> vl.c | 10 ++++++++++
> qapi/ui.json | 13 +++++++++++++
> 2 files changed, 23 insertions(+)
Conflicts with d4dc4ab1, but the resolution is obvious. Makes sense as
3.1 material given that d4dc4ab1 is less useful without this.
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-11-20 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 8:56 [Qemu-devel] [PATCH] qapi: add query-display-options command Gerd Hoffmann
2018-11-20 16:00 ` Eric Blake [this message]
2018-11-21 10:09 ` Erik Skultety
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9abccebe-4bff-bc35-4fe2-fedbf23314fe@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=eskultet@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).