From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: eblake@redhat.com, armbru@redhat.com, kwolf@redhat.com,
jsnow@redhat.com, famz@redhat.com, den@openvz.org,
nshirokovskiy@virtuozzo.com, mnestratov@virtuozzo.com
Subject: Re: [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps
Date: Wed, 31 Jan 2018 20:04:06 +0100 [thread overview]
Message-ID: <9ac62cef-4331-a828-5c4d-b7a2fdd7b6b5@redhat.com> (raw)
In-Reply-To: <7a5ef265-c266-21e7-f82d-bee77062111c@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On 2018-01-29 19:43, Max Reitz wrote:
> On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote:
>> To maintain load/store disabled bitmap there is new approach:
>>
>> - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored
>> - store enabled bitmaps as "auto" to qcow2
>> - store disabled bitmaps without "auto" flag to qcow2
>> - on qcow2 open load "auto" bitmaps as enabled and others
>> as disabled (except in_use bitmaps)
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> Reviewed-by: John Snow <jsnow@redhat.com>
>> ---
>
> Thanks, looks very reasonable. Applied to my block branch:
>
> https://github.com/XanClic/qemu/commits/block
...aaand I've only just now seen that iotest 176 will need to be fixed
along with this, so I'm going to unqueue this patch for now.
And when I'm already at it: Should we add deprecation information to
qemu-doc.texi?
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2018-01-31 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 10:41 [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps Vladimir Sementsov-Ogievskiy
2018-01-29 18:43 ` Max Reitz
2018-01-31 19:04 ` Max Reitz [this message]
2018-02-02 15:18 ` Vladimir Sementsov-Ogievskiy
2018-02-02 15:23 ` Max Reitz
2018-02-02 15:30 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ac62cef-4331-a828-5c4d-b7a2fdd7b6b5@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mnestratov@virtuozzo.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).