qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	"Stefan Hajnoczi" <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: Maintainers, please add Message-Id: when merging patches
Date: Wed, 22 Jan 2020 15:10:08 +0100	[thread overview]
Message-ID: <9ac75d71-731d-a9d8-4ba6-f394077c4d96@redhat.com> (raw)
In-Reply-To: <87v9p3znas.fsf@linaro.org>

On 01/22/20 13:30, Alex Bennée wrote:
> 
> Stefan Hajnoczi <stefanha@gmail.com> writes:
> 
>> Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag.  Hooray!
>>
>> Message-Id: references the patch email that a commit was merged from.
>> This information is helpful to anyone wishing to refer back to email
>> discussions and patch series.
> 
> So I guess the ones that don't are maintainer originated patches unless
> you actively rebuild your trees from a posted series?

I *think* this should not be a huge problem process wise:

Assuming that a maintainer does not include their own patches in a PULL
request for Peter until the same patches receive R-b/A-b/T-b feedback
from other list subscribers, the maintainer will want to rebase the
patches at least once anyway, in order to pick up those lines.

And, in the process, the maintainer might as well add in their own
Message-Id's from the list.

... I realize though, that could be more burden in practice than just
running git-am against the same (known) base commit... One could always
run git-range-diff in the end, to compare the "re-pick" versus the
original local branch.

Thanks
Laszlo



  parent reply	other threads:[~2020-01-22 14:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 12:02 Maintainers, please add Message-Id: when merging patches Stefan Hajnoczi
2020-01-22 12:28 ` Kevin Wolf
2020-01-23 17:18   ` Kevin Wolf
2020-01-23 21:23     ` Laszlo Ersek
2020-01-24 10:58     ` Stefan Hajnoczi
2020-01-22 12:30 ` Alex Bennée
2020-01-22 13:51   ` Cornelia Huck
2020-01-22 14:10   ` Laszlo Ersek [this message]
2020-01-22 18:56     ` Alex Bennée
2020-01-22 19:07       ` Cornelia Huck
2020-01-23  9:41         ` Laszlo Ersek
2020-01-22 14:26   ` Gerd Hoffmann
2020-01-23  8:27   ` Markus Armbruster
2020-01-23 11:17     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ac75d71-731d-a9d8-4ba6-f394077c4d96@redhat.com \
    --to=lersek@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).