Re: [PATCH 2/2] seabios: remove PCI drivers from bios.bin

[Thomas Huth <thuth@redhat.com>]

On 21/09/2023 14.10, Paolo Bonzini wrote:
> bios.bin is now used only by ISA PC, so PCI drivers are not necessary.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   pc-bios/bios.bin         | Bin 131072 -> 131072 bytes
>   roms/config.seabios-128k |  30 ++++++++++++++++++++++--------
>   2 files changed, 22 insertions(+), 8 deletions(-)
...
> diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k
> index d18c802c46e..06f4ba35bbe 100644
> --- a/roms/config.seabios-128k
> +++ b/roms/config.seabios-128k
> @@ -1,21 +1,35 @@
> -# for qemu machine types 1.7 + older
> -# need to turn off features (xhci,uas) to make it fit into 128k
> +# SeaBIOS Configuration for -M isapc
> +
> +#
> +# General Features
> +#
>   CONFIG_QEMU=y
>   CONFIG_ROM_SIZE=128
>   CONFIG_ATA_DMA=n
>   CONFIG_BOOTSPLASH=n
>   CONFIG_XEN=n
> -CONFIG_USB_OHCI=n
> -CONFIG_USB_XHCI=n
> -CONFIG_USB_UAS=n
> +CONFIG_ATA_PIO32=n
> +CONFIG_AHCI=n
>   CONFIG_SDCARD=n
>   CONFIG_TCGBIOS=n
> -CONFIG_MPT_SCSI=n
> -CONFIG_ESP_SCSI=n
> -CONFIG_MEGASAS=n
> +CONFIG_VIRTIO_BLK=n
> +CONFIG_VIRTIO_SCSI=n
>   CONFIG_PVSCSI=n
> +CONFIG_ESP_SCSI=n
> +CONFIG_LSI_SCSI=n
> +CONFIG_MEGASAS=n
> +CONFIG_MPT_SCSI=n

Why did you change the order of MPT, ESP and MEGASAS?

Apart from that, wrt to the config file changes:
Reviewed-by: Thomas Huth <thuth@redhat.com>

>   CONFIG_NVME=n
>   CONFIG_USE_SMM=n
>   CONFIG_VGAHOOKS=n
>   CONFIG_HOST_BIOS_GEOMETRY=n
> +CONFIG_PS2PORT=n
> +CONFIG_USB=n
> +CONFIG_PMTIMER=n
> +CONFIG_PCIBIOS=n
> +CONFIG_DISABLE_A20=n
> +CONFIG_WRITABLE_UPPERMEMORY=n
> +CONFIG_ACPI=n
>   CONFIG_ACPI_PARSE=n
> +CONFIG_DEBUG_SERIAL=n
> +CONFIG_DEBUG_SERIAL_MMIO=n