From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTnJ9-0003Ym-Bz for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:41:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTnJ4-0003Xw-RU for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:41:19 -0400 Received: from [199.232.76.173] (port=35443 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTnJ4-0003Xt-Oa for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:41:14 -0400 Received: from mail-yx0-f188.google.com ([209.85.210.188]:32905) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTnJ4-0006Ul-03 for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:41:14 -0400 Received: by yxe26 with SMTP id 26so1027810yxe.4 for ; Wed, 22 Jul 2009 18:41:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1248313054.14831.36.camel@localhost.localdomain> References: <1248313054.14831.36.camel@localhost.localdomain> Date: Thu, 23 Jul 2009 01:41:07 +0000 Message-ID: <9ae48b020907221841q392c58b7k20f560f8a5e99fc2@mail.gmail.com> From: Ed Swierk Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] slirp: Remove our_addr code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jul 23, 2009 at 1:37 AM, Ed Swierk wrote: > - It's useless: aside from the CU-SeeMe protocol emulation which I > propose removing, the only other reference is in get_dns_addr(), but > can't imagine why you would want to send DNS requests to a different IP > address if you're running a DNS server on the host and resolv.conf > points to 127.0.0.1. > > These problems are easily solved by removing the code. Note that VirtualBox removed this code recently as well: http://www.virtualbox.org/ticket/1470 . --Ed