From: Ed Swierk <eswierk@aristanetworks.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, qemu-devel@nongnu.org,
linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
Sridhar Samudrala <sri@us.ibm.com>
Subject: [Qemu-devel] Re: [PATCH 1/2] macvtap: rework object lifetime rules
Date: Mon, 15 Feb 2010 15:48:40 -0800 [thread overview]
Message-ID: <9ae48b021002151548l79b8c5fdycc04a2f36fed1f09@mail.gmail.com> (raw)
In-Reply-To: <201002131133.43028.arnd@arndb.de>
On Sat, Feb 13, 2010 at 2:33 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The original macvtap code has a number of problems
> resulting from the use of RCU for protecting the
> access to struct macvtap_queue from open files.
>
> This includes
> - need for GFP_ATOMIC allocations for skbs
> - potential deadlocks when copy_*_user sleeps
> - inability to work with vhost-net
>
> Changing the lifetime of macvtap_queue to always
> depend on the open file solves all these. The
> RCU reference simply moves one step down to
> the reference on the macvlan_dev, which we
> only need for nonblocking operations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This works for me.
Acked-by: Ed Swierk <eswierk@aristanetworks.com>
prev parent reply other threads:[~2010-02-15 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 10:33 [Qemu-devel] [PATCH 1/2] macvtap: rework object lifetime rules Arnd Bergmann
2010-02-13 10:35 ` [Qemu-devel] [PATCH 2/2] net/macvtap: add vhost support Arnd Bergmann
2010-02-14 13:27 ` [Qemu-devel] " Michael S. Tsirkin
2010-02-15 9:20 ` [Qemu-devel] Re: [PATCH 2/2] net/macvtap: add vhost suppor Arnd Bergmann
2010-02-15 23:48 ` Ed Swierk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae48b021002151548l79b8c5fdycc04a2f36fed1f09@mail.gmail.com \
--to=eswierk@aristanetworks.com \
--cc=arnd@arndb.de \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).