Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

[Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>]

W dniu 29.08.2023 o 15:57, Philippe Mathieu-Daudé pisze:
> On 29/8/23 13:39, Marcin Juszkiewicz wrote:

>> Does someone know where the problem may be? And how to fix it?
> 
> Commit fb23162885 ("pci: initialize pci config headers depending it pci
> header type.") sets PCI_SEC_LATENCY_TIMER writable; it seems to be a
> mistake (and bsa-acs is doing the correct testing).
> 
> Can you try this quick fix?
> 
> -- >8 --
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 881d774fb6..e43aa0fb36 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -894,5 +895,4 @@ static void pci_init_mask_bridge(PCIDevice *d)
>   {
> -    /* PCI_PRIMARY_BUS, PCI_SECONDARY_BUS, PCI_SUBORDINATE_BUS and
> -       PCI_SEC_LETENCY_TIMER */
> -    memset(d->wmask + PCI_PRIMARY_BUS, 0xff, 4);
> +    /* PCI_PRIMARY_BUS, PCI_SECONDARY_BUS, PCI_SUBORDINATE_BUS */
> +    memset(d->wmask + PCI_PRIMARY_BUS, 0xff, 3);

It made test pass:

  822 : Check Type 1 config header rules           : Result:  PASS