Re: [Qemu-devel] [PATCH v3 0/9] s390x: zPCI detangling

[Christian Borntraeger <borntraeger@de.ibm.com>]

On 07/25/2017 05:33 PM, Cornelia Huck wrote:
> Next version, now without RFC. The goals are still the same:
> - Being able to disable PCI support in a build completely.
> - Properly fencing off PCI if the relevant facility bit is not provided.
> 
> Changes v2->v3:
> - Only enable the zpci bit conditionally, keep the aen bit always on.
>   Use a method that actually works...
> - Some reordering in the msi route patch to keep the change small.
> - Collected some r-bs.
> 
> Branch is still git://github.com/cohuck/qemu no-zpci-cpumodel
> 
> Likely 2.11 material, even though the 'fence off if facility bit is not
> set' part could count as bugfixes. Thoughts?

In general, this series looks pretty good already, but I would prefer to
have it in 2.11. The PCI code now seems to work ok for passthrough devices
and this change would certainly require some retesting. 
I think it would stretch things too far to consider the fencing a 
must have bug fix.

> 
> Cornelia Huck (9):
>   kvm: remove hard dependency on pci
>   s390x/pci: add stubs
>   s390x: chsc nt2 events are pci-only
>   s390x/pci: do not advertise pci on non-pci builds
>   s390x/ccw: create s390 phb conditionally
>   s390x/sclp: properly guard pci-specific functions
>   s390x/pci: fence off instructions for non-pci
>   s390x/kvm: msi route fixup for non-pci
>   s390x: refine pci dependencies
> 
>  default-configs/s390x-softmmu.mak |  2 +-
>  hw/pci/pci-stub.c                 | 12 ++++++
>  hw/s390x/Makefile.objs            |  3 +-
>  hw/s390x/s390-pci-bus.c           |  9 ++++-
>  hw/s390x/s390-pci-bus.h           |  5 ++-
>  hw/s390x/s390-pci-stub.c          | 78 +++++++++++++++++++++++++++++++++++++++
>  hw/s390x/s390-virtio-ccw.c        | 12 +++---
>  hw/s390x/sclp.c                   | 19 ++++++++--
>  target/s390x/ioinst.c             | 16 ++++++++
>  target/s390x/kvm.c                | 61 +++++++++++++++++++++++-------
>  10 files changed, 188 insertions(+), 29 deletions(-)
>  create mode 100644 hw/s390x/s390-pci-stub.c
>