From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Fdpel-0003VZ-G6
	for qemu-devel@nongnu.org; Wed, 10 May 2006 10:27:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Fdpej-0003Tq-Qy
	for qemu-devel@nongnu.org; Wed, 10 May 2006 10:27:15 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Fdpej-0003Th-OR
	for qemu-devel@nongnu.org; Wed, 10 May 2006 10:27:13 -0400
Received: from [64.233.184.235] (helo=wr-out-0506.google.com)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fdpg2-0007Xn-F6
	for qemu-devel@nongnu.org; Wed, 10 May 2006 10:28:34 -0400
Received: by wr-out-0506.google.com with SMTP id i30so1416026wra
	for <qemu-devel@nongnu.org>; Wed, 10 May 2006 07:27:11 -0700 (PDT)
Message-ID: <9b0d5f320605100727ga99046br4f89afc8cb256d38@mail.gmail.com>
Date: Wed, 10 May 2006 10:27:03 -0400
From: WaxDragon <waxdragon@gmail.com>
Subject: Re: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows
In-Reply-To: <7F740D512C7C1046AB53446D3720017307E75ED4@scsmsx402.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <7F740D512C7C1046AB53446D3720017307E75ED4@scsmsx402.amr.corp.intel.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I tried out this patch (with CVS, after fixing it) with XP SP2 and 2k3
SP1.  It did address the corruption when changing bpp or resolution,
but paints the screen white while the UI elements repaint themselves.=20
Just a little disturbing, but I'll get used to it.  Also, I had the
leave the second chunk in, otherwise XP failed to paint much of the
screen upon bootup.

Index: hw/cirrus_vga.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /sources/qemu/qemu/hw/cirrus_vga.c,v
retrieving revision 1.21
diff -u -r1.21 cirrus_vga.c
--- hw/cirrus_vga.c     30 Apr 2006 21:28:36 -0000      1.21
+++ hw/cirrus_vga.c     10 May 2006 14:08:25 -0000
@@ -1181,6 +1181,17 @@
        break;
     case 0x05:                 // ???
     case 0x07:                 // Extended Sequencer Mode
+       /* Win2K seems to assume that the VRAM is set to 0xff
+        *   whenever VGA/SVGA mode changes
+        */
+    if ((s->sr[0x07] ^ *reg_value) & CIRRUS_SR7_BPP_SVGA)
+        memset(s->vram_ptr, 0xff, s->real_vram_size);
+    *reg_value =3D s->sr[0x07];
+#ifdef DEBUG_CIRRUS
+    printf("cirrus: handled outport sr_index %02x, sr_value %02x\n",
+           reg_index, reg_value);
+#endif
+    break;
     case 0x08:                 // EEPROM Control
     case 0x09:                 // Scratch Register 0
     case 0x0a:                 // Scratch Register 1


WD
--
ReactOS is a hub, follow the spokes and you'll
immediately find absolutely everything you need
to know about Windows.  ReactOS is not just
software, it's people.
                                        kjk_hyperion