From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message
Date: Mon, 16 Jan 2017 18:16:22 +0100 [thread overview]
Message-ID: <9b2b5e83-a875-745e-4f19-6f9e53f3b9a0@redhat.com> (raw)
In-Reply-To: <20161201020508.24417-1-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On 01.12.2016 03:05, Max Reitz wrote:
> When trying to invoke qemu-img commit with a base image file name that
> is not part of the top image's backing chain, the user receives a rather
> plain "Base not found" error message. This is not really helpful because
> it does not explain what "not found" means, potentially leaving the user
> wondering why qemu cannot find a file despite it clearly existing in the
> file system.
>
> Improve the error message by clarifying that "not found" means "not
> found in the top image's backing chain".
>
> Reported-by: Ala Hino <ahino@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Reported in: https://bugzilla.redhat.com/show_bug.cgi?id=1390991
> ---
> qemu-img.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to my block tree.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
prev parent reply other threads:[~2017-01-16 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 2:05 [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message Max Reitz
2016-12-01 2:36 ` Eric Blake
2016-12-01 23:38 ` Max Reitz
2017-01-16 17:16 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2b5e83-a875-745e-4f19-6f9e53f3b9a0@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).