From: Maxim Levitsky <mlevitsk@redhat.com>
To: Klaus Jensen <its@irrelevant.dk>, qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Beata Michalska" <beata.michalska@linaro.org>,
"Klaus Jensen" <k.jensen@samsung.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Javier Gonzalez" <javier.gonz@samsung.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v5 06/18] nvme: refactor nvme_addr_read
Date: Tue, 05 May 2020 15:10:15 +0300 [thread overview]
Message-ID: <9b2ebceafa7a5c6598cfcb32120569b656f21fad.camel@redhat.com> (raw)
In-Reply-To: <20200505055252.dtk3w355nrcfmszs@apples.localdomain>
On Tue, 2020-05-05 at 07:52 +0200, Klaus Jensen wrote:
> On May 5 07:48, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > Pull the controller memory buffer check to its own function. The check
> > will be used on its own in later patches.
> >
> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Reviewed-by: Maxim Levitsky <mlevitsky@redhat.com>
> > Reviewed-by: Keith Busch <kbusch@kernel.org>
> > ---
> > hw/block/nvme.c | 16 ++++++++++++----
> > 1 file changed, 12 insertions(+), 4 deletions(-)
> >
>
> Woops, noticed that Maxim's R-b is wrong here, please update it to
>
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
>
> (without the 'y') when merging.
>
Well. When I worked for Intel, my email used to be mlevtsky@intel.com,
because I misspelled my private email (maximlevitsky@gmail.com) in my CV, and somehow this got
propagated to my username there.
Sure enough when I applied to work for Red Hat, I triple checked this to avoid such a mistake.
Well.... our usernames are limited to 8 characters.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2020-05-05 12:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 5:48 [PATCH v5 00/18] nvme: refactoring and cleanups Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 01/18] nvme: fix pci doorbell size calculation Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 02/18] nvme: rename trace events to pci_nvme Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 03/18] nvme: remove superfluous breaks Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 04/18] nvme: move device parameters to separate struct Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 05/18] nvme: use constants in identify Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 06/18] nvme: refactor nvme_addr_read Klaus Jensen
2020-05-05 5:52 ` Klaus Jensen
2020-05-05 12:10 ` Maxim Levitsky [this message]
2020-05-05 5:48 ` [PATCH v5 07/18] nvme: add max_ioqpairs device parameter Klaus Jensen
2020-05-05 20:52 ` Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 08/18] nvme: remove redundant cmbloc/cmbsz members Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 09/18] nvme: factor out property/constraint checks Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 10/18] nvme: factor out device state setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 11/18] nvme: factor out block backend setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 12/18] nvme: add namespace helpers Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 13/18] nvme: factor out namespace setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 14/18] nvme: factor out pci setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 15/18] nvme: factor out cmb setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 16/18] nvme: factor out pmr setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 17/18] nvme: do cmb/pmr init as part of pci init Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 18/18] nvme: factor out controller identify setup Klaus Jensen
2020-05-05 9:41 ` [PATCH v5 00/18] nvme: refactoring and cleanups Philippe Mathieu-Daudé
2020-05-11 6:25 ` Klaus Jensen
2020-05-11 7:00 ` Philippe Mathieu-Daudé
2020-05-11 7:09 ` Klaus Jensen
2020-05-11 12:50 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2ebceafa7a5c6598cfcb32120569b656f21fad.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=its@irrelevant.dk \
--cc=javier.gonz@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).