From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: marcandre.lureau@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr()
Date: Thu, 12 Jan 2017 12:19:21 +0100 [thread overview]
Message-ID: <9b2f5d9e-34f1-043b-346c-cab477376163@redhat.com> (raw)
In-Reply-To: <20170112094606.GO4450@pxdev.xzpeter.org>
On 12/01/2017 10:46, Peter Xu wrote:
> Yes, above suggestion makes sense to me, since after all the RW
> permissions are derived from the type of memory regions, and the type
> itself tells more things than the RW bits. So I totally agree we can
> replace the "RW" chars with its type directly (if no one else
> disagree, of course).
>
> While for below patch, do you want me to include it as well as a
> standalone patch, for the purpose of refactoring
> memory_access_is_direct()? Since IMHO it's tiny clearer and more
> readable than before.
It is more readable, but my plan was to turn these fields into a single
field (with bits) to speed up memory_access_is_direct. For that we'd
need to undo your change. So I'm undecided.
Paolo
next prev parent reply other threads:[~2017-01-12 11:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 7:58 [Qemu-devel] [PATCH v2 0/2] memory: extend "info mtree" with flat view dump Peter Xu
2016-12-21 7:58 ` [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr() Peter Xu
2017-01-11 17:21 ` Paolo Bonzini
2017-01-12 5:50 ` Peter Xu
2017-01-12 8:54 ` Paolo Bonzini
2017-01-12 9:46 ` Peter Xu
2017-01-12 11:19 ` Paolo Bonzini [this message]
2017-01-12 13:09 ` Peter Xu
2016-12-21 7:58 ` [Qemu-devel] [PATCH v2 2/2] memory: hmp: dump flat view for 'info mtree' Peter Xu
2017-01-11 17:13 ` Paolo Bonzini
2017-01-12 5:53 ` Peter Xu
2017-01-11 6:20 ` [Qemu-devel] [PATCH v2 0/2] memory: extend "info mtree" with flat view dump Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2f5d9e-34f1-043b-346c-cab477376163@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).