From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1yfn-0001c0-JD for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:46:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1yfj-00058J-M1 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:45:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42268) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1yfj-00057t-Fq for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:45:55 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A17B664D85 for ; Wed, 2 Nov 2016 16:45:54 +0000 (UTC) References: <1478103841-8686-1-git-send-email-pbonzini@redhat.com> <20161102164031.GD17900@redhat.com> From: Paolo Bonzini Message-ID: <9b43027f-716f-bcbd-6d74-31b368b4600c@redhat.com> Date: Wed, 2 Nov 2016 17:45:51 +0100 MIME-Version: 1.0 In-Reply-To: <20161102164031.GD17900@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.8?] rules.mak: speedup save-vars load-vars List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, famz@redhat.com On 02/11/2016 17:40, Daniel P. Berrange wrote: > Could we instead just do: > > Makefile.objs: > > util-obj-y = > include util/Makefile.objs > > util/Makefile.objs: > util-obj-y += util/osdep.o util/cutils.o util/unicode.o > > Yes, you now get the "burden" of adding a directory prefix onto the file > paths, but I don't think that's a big deal, as it is only a one-time > cost when you create a new file, or very rarely move files between dirs. I don't think the simplification would be that much. In particular, note that you would keep some of the complication to process *-cflags, *-libs and *-objs variables, and you would have additional complication to handle the prepending of ".." in Makefile.target. Paolo > Without the unnest-vars black magic I think it'd be simpler for mere > mortals to understand what is happening in the makefiles, lowering > the barrier to entry for new contributors to QEMU (and even existing > QEMU contributors who've not had the misfortune of debugging our > recursive make system yet) > > Regards, > Daniel >