From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD2BC31E46 for ; Wed, 12 Jun 2019 19:29:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65AB1215EA for ; Wed, 12 Jun 2019 19:29:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65AB1215EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb8wM-0002Su-LC for qemu-devel@archiver.kernel.org; Wed, 12 Jun 2019 15:29:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38951) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb8vH-0001qd-4n for qemu-devel@nongnu.org; Wed, 12 Jun 2019 15:28:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb8vF-0000t0-Vp for qemu-devel@nongnu.org; Wed, 12 Jun 2019 15:28:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39042) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hb8vD-0000pc-V1; Wed, 12 Jun 2019 15:28:36 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A5B33005029; Wed, 12 Jun 2019 19:28:27 +0000 (UTC) Received: from [10.3.116.85] (ovpn-116-85.phx2.redhat.com [10.3.116.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0C7E614C8; Wed, 12 Jun 2019 19:28:22 +0000 (UTC) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org References: <20190611145556.12940-1-rfried.dev@gmail.com> <87o932el61.fsf@zen.linaroharston> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <9b51858e-a876-aff8-15f7-228f659d0d20@redhat.com> Date: Wed, 12 Jun 2019 14:28:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87o932el61.fsf@zen.linaroharston> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nqWT9CePoK38wY5NuvbMp6T1rdnHuRb7x" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 12 Jun 2019 19:28:33 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v2] net: cadence_gem: fix compilation error when debug is on X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Jason Wang , Alistair Francis , qemu-devel@nongnu.org, Ramon Fried Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nqWT9CePoK38wY5NuvbMp6T1rdnHuRb7x Content-Type: multipart/mixed; boundary="KbisJ2eFc9eFgnTLpn7xOErVdRpYBM2XN"; protected-headers="v1" From: Eric Blake To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org Cc: Peter Maydell , qemu-trivial@nongnu.org, Jason Wang , Alistair Francis , qemu-devel@nongnu.org, Ramon Fried Message-ID: <9b51858e-a876-aff8-15f7-228f659d0d20@redhat.com> Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v2] net: cadence_gem: fix compilation error when debug is on References: <20190611145556.12940-1-rfried.dev@gmail.com> <87o932el61.fsf@zen.linaroharston> In-Reply-To: <87o932el61.fsf@zen.linaroharston> --KbisJ2eFc9eFgnTLpn7xOErVdRpYBM2XN Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/12/19 1:03 PM, Alex Benn=C3=A9e wrote: >=20 > Ramon Fried writes: >=20 >> defining CADENCE_GEM_ERR_DEBUG causes compilation >> errors, fix that. >=20 > It would be worth doing something like: >=20 > #ifdef CADENCE_GEM_ERR_DEBUG > #define CADENCE_GEM_GATE 1 > #else > #define CADENCE_GEM_GATE 0 > #endif >=20 > #define DB_PRINT(...) do { \ > if (CADENCE_GEM_GATE) { \ > fprintf(stderr, ": %s: ", __func__); \ > fprintf(stderr, ## __VA_ARGS__); \ > } \ > } while (0) >=20 > So these format strings don't go stale in and only get detected on > --debug builds. >=20 > While your at it I suspect the fprintf debug would be better of as: >=20 > qemu_log("%s: " fmt, __func__, ## args); Indeed, or even see if it is worth converting to full-on trace points for dynamic control of whether to catch these things without having to recompile debug on or off. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --KbisJ2eFc9eFgnTLpn7xOErVdRpYBM2XN-- --nqWT9CePoK38wY5NuvbMp6T1rdnHuRb7x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0BUlUACgkQp6FrSiUn Q2pQ6ggAjV8iNpm2REHcnw/PqW1/AYUeokG6l/zMqUTeSN8/bjjaw4GrC6r8ICe4 ms4VPK43DjxfIxCkZ3Bz7GRVT4Qw8PUhbB0WsWaO8AhNvcIYgasmsvlAMJrUzRRq n15YmZ2EYf+pWMWnrQXzsW2nYr5JgC8kfxTB38IYYMBU9hHMiFk54hbruO2zrCVu O2immF9st2C7261umVRpr4mzNqMrByyylK+flgztyq9Cd0qWhNCfU2C24omzutMi ooI92IoYaduvbLk4W29oarloN8WE7AMQPUgthjVuNPZhBFv8COrPmKW3tDlj1Dn3 1bbEseoc/U33NWNnrH7qsiSGdetozA== =NQyf -----END PGP SIGNATURE----- --nqWT9CePoK38wY5NuvbMp6T1rdnHuRb7x--