From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <huth@tuxfamily.org>, qemu-devel@nongnu.org
Subject: Re: [PULL 5/6] hw/m68k/mcf5206: Replace remaining hw_error()s by qemu_log_mask()
Date: Mon, 6 Jul 2020 09:36:39 +0200 [thread overview]
Message-ID: <9b84407f-cf8d-b733-6db1-0c50c9a0f33f@redhat.com> (raw)
In-Reply-To: <20200706072835.23582-6-thuth@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 940 bytes --]
On 06/07/2020 09.28, Thomas Huth wrote:
> From: Thomas Huth <huth@tuxfamily.org>
>
> hw_error() dumps the CPU state and exits QEMU. This is ok during initial
> code development (to see where the guest code is currently executing),
> but it is certainly not the desired behavior that we want to present to
> normal users, and it can also cause trouble when e.g. fuzzing devices.
> Thus let's replace these hw_error()s by qemu_log_mask()s instead.
>
> Message-Id: <20200611055807.15921-1-huth@tuxfamily.org>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Thomas Huth <thuth@tuxfamily.org>
I just noticed that I had a typo in my e-mail address here :-(
Peter, FYI, I fixed it and pushed the same tag (pull-request-2020-07-06)
again, latest commit ID is now 8c4329214f1d4484205e6f7c48e98ff26969eb56.
Sorry for the inconvenience.
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-06 7:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 7:28 [PULL 0/6] qtest and misc patches Thomas Huth
2020-07-06 7:28 ` [PULL 1/6] fuzz: fix broken qtest check at rcu_disable_atfork Thomas Huth
2020-07-06 7:28 ` [PULL 2/6] fuzz: do not use POSIX shm for coverage bitmap Thomas Huth
2020-07-06 7:28 ` [PULL 3/6] tests/qtest: Unify the test for the xenfv and xenpv machines Thomas Huth
2020-07-06 7:28 ` [PULL 4/6] configure / util: Auto-detect the availability of openpty() Thomas Huth
2020-07-06 7:28 ` [PULL 5/6] hw/m68k/mcf5206: Replace remaining hw_error()s by qemu_log_mask() Thomas Huth
2020-07-06 7:36 ` Thomas Huth [this message]
2020-07-06 7:28 ` [PULL 6/6] tests/acceptance: Add a test for the sun4u sparc64 machine Thomas Huth
2020-07-07 15:20 ` [PULL 0/6] qtest and misc patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b84407f-cf8d-b733-6db1-0c50c9a0f33f@redhat.com \
--to=thuth@redhat.com \
--cc=huth@tuxfamily.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).