From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DDC2C4332F for ; Wed, 8 Nov 2023 18:00:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0mq5-0003P3-FE; Wed, 08 Nov 2023 12:59:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0mpq-0003Ec-HH for qemu-devel@nongnu.org; Wed, 08 Nov 2023 12:59:29 -0500 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0mpn-00055R-QW for qemu-devel@nongnu.org; Wed, 08 Nov 2023 12:59:26 -0500 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9becde9ea7bso230454466b.0 for ; Wed, 08 Nov 2023 09:59:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699466360; x=1700071160; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zCIV6xhOEy9e0/ump87scJTxEKubosmfb6SjXkR8ygA=; b=eZScp0DsAYKLUHY38/aaergN2iNLsRYskutobN92uNvh5rO5vxUGxWatpaPya4gZ8z 0+m3/NHf1FUTg0U1+S5LxmWTOS4ZHrqX/vgBELEGFv4jKWW+5eqH9RGJBw8bdvSOrVmR rGRBJe0tKziiMYqXjM5bYeUrW72oKWY51A0ZjGWvwHAuE07JGDA7/GDJEB0MMoo/zTel ZaXR3+ebJwfcqJb2AmsiXsX8IGkrBR6m8cK8x9tqt/OOxO81NVmOJ3FTk5PDZTr+Adrw JN23mdxsTtMdb9Iyms+8lKr5B3WnY+7+9FOrpQHyYFXvg6zt8s2xJNWlp9iarTlOTiia J6YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699466360; x=1700071160; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zCIV6xhOEy9e0/ump87scJTxEKubosmfb6SjXkR8ygA=; b=bAF4JtPdMTglSQNsjgvUFXrIZPlAdqr1pG5bgygPJynEhqOBvnIQEiTAWEf/K7hdGs kM+smEGx1CtZZhjvYmP0g6LY984D5j0bELQOgC7MxJwchsEx4y3fKsUOIEGurxoKkoY3 us4N/tw3pYSNsT1n2VHATOI+SHMBISdJYf5vrPx4stvrd53++TNYUd9Ct06MbyHaVrh8 tmBQMgxD/WIitlUgfRYoJjKwqPVbK/esIPGzw8YiOi++LgyBQ3JO0E/py37SGl5TduIx r6/5DEd2EJTKx3DSE7KHj50+kPwDlSTA9NA2Gmb4mgAyFk+LN6BuqO8CW5Ir6PItffsr RPVA== X-Gm-Message-State: AOJu0Yz9q7teDMu+Nnt2MS4yVhNbRBUs8U+C0Q5e7ueEDQ0K2v6C07m5 nHTw1btqvW1fxg4H5/DTXrFKQI0CPSVjgvxSBxc= X-Google-Smtp-Source: AGHT+IGuPOohKZmFAgddJF1Co9ORgC/M2PL3kwQZM2KEaGUVD9y8ARx/pHRC01ExEv4I0J+4gd5fAg== X-Received: by 2002:a17:907:7246:b0:9a9:f0e6:904e with SMTP id ds6-20020a170907724600b009a9f0e6904emr2745557ejc.16.1699466360431; Wed, 08 Nov 2023 09:59:20 -0800 (PST) Received: from [192.168.69.115] ([176.187.199.60]) by smtp.gmail.com with ESMTPSA id lv19-20020a170906bc9300b009a9fbeb15f5sm1372376ejb.46.2023.11.08.09.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 09:59:19 -0800 (PST) Message-ID: <9ba58d8f-0554-439e-b93d-b6e06fafe3d0@linaro.org> Date: Wed, 8 Nov 2023 18:59:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/35 2/2] tcg/arm: Support TCG_COND_TST{EQ,NE} Content-Language: en-US To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-arm@nongnu.org References: <20231028194522.245170-12-richard.henderson@linaro.org> <20231108145244.72421-2-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20231108145244.72421-2-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=philmd@linaro.org; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/11/23 15:52, Philippe Mathieu-Daudé wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Message-Id: <20231028194522.245170-12-richard.henderson@linaro.org> > [PMD: Split from bigger patch, part 2/2] > Signed-off-by: Philippe Mathieu-Daudé > --- > tcg/arm/tcg-target.c.inc | 29 ++++++++++++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc > index 66d71af8bf..0fc7273b16 100644 > --- a/tcg/arm/tcg-target.c.inc > +++ b/tcg/arm/tcg-target.c.inc > @@ -1194,7 +1194,27 @@ static void tcg_out_mb(TCGContext *s, TCGArg a0) > static TCGCond tcg_out_cmp(TCGContext *s, TCGCond cond, TCGReg a, > TCGArg b, int b_const) > { > - tcg_out_dat_rIN(s, COND_AL, ARITH_CMP, ARITH_CMN, 0, a, b, b_const); > + if (!is_tst_cond(cond)) { > + tcg_out_dat_rIN(s, COND_AL, ARITH_CMP, ARITH_CMN, 0, a, b, b_const); > + return cond; > + } > + > + cond = tcg_tst_eqne_cond(cond); > + if (b_const) { > + int imm12 = encode_imm(b); > + > + /* > + * The compare constraints allow rIN, but TST does not support N. > + * Be prepared to load the constant into a scratch register. > + */ > + if (imm12 >= 0) { > + tcg_out_dat_imm(s, COND_AL, ARITH_TST, 0, a, imm12); > + return cond; > + } > + tcg_out_movi32(s, COND_AL, TCG_REG_TMP, b); > + b = TCG_REG_TMP; > + } > + tcg_out_dat_reg(s, COND_AL, ARITH_TST, 0, a, b, SHIFT_IMM_LSL(0)); > return cond; > } To the best of my knowledge, Reviewed-by: Philippe Mathieu-Daudé