From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C01F2D3C92D for ; Wed, 10 Dec 2025 16:18:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vTMtX-0006qh-Fm; Wed, 10 Dec 2025 11:18:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTMtR-0006pw-MS for qemu-devel@nongnu.org; Wed, 10 Dec 2025 11:18:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTMtP-0006lx-Tm for qemu-devel@nongnu.org; Wed, 10 Dec 2025 11:18:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765383499; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8mSvb0XM6v8n+4ZgqoXh4wmc/kH8env7IqTdZ9CAFVo=; b=TEKo9rlBhcaFsRcX/O5nzBK3ATtUJpAfplVH+kOu+Uw3lDwBWH9dFhajbt4uVfAL2bn1tC KuykWP5sqimat2RjudOcQH0bjKT27YM6MlUkjPCayWiA5qtcCFHT2r6SCJsozyLnfTJGAV IHzkKmbtGjoeosB2WgC8NGwfRyQxvyE= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-rL9aHewRPAuD3lQnz8uGIg-1; Wed, 10 Dec 2025 11:18:12 -0500 X-MC-Unique: rL9aHewRPAuD3lQnz8uGIg-1 X-Mimecast-MFC-AGG-ID: rL9aHewRPAuD3lQnz8uGIg_1765383492 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed69f9ce96so227348691cf.3 for ; Wed, 10 Dec 2025 08:18:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765383492; x=1765988292; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8mSvb0XM6v8n+4ZgqoXh4wmc/kH8env7IqTdZ9CAFVo=; b=nreKeO87c5VhYwaZwiq15UAhuyNByVjzlioLLzlm7EL/2mAJlglFIZ+k6aih55zvmE do8F4x+tgjWpckwy3zLaBsGRQOs/9nwTaq9nJWXCb4TZTv1hQqg8182HsSv9zxpG8JAM g9liQU6RG5oQhHldUng9fslSao/TzM/j2AATbONe5a8K9+DfH8IIya1qKct59KtKF6pT 0hEn3ANAhAmHAMfvq4Wn/wn9VlYvZaN7lC9cBZKkQb3L9v+G+Asi/DCQY4riVX2Q55qu d+Rxi02j+9dkYJkzn9Rrq8vh6bn7oZlZg3F0JxZo+UDuKxhMvaYaYFcEktxYmdugrkcv bJjQ== X-Forwarded-Encrypted: i=1; AJvYcCXGHS/aUlto2FHJnrHkFXi68rC8saSa3aGCwhUxhXNYCk71ubpQoVdULo0/US01wHEjSbQYS+f7MHBu@nongnu.org X-Gm-Message-State: AOJu0YyCwfJlRpjQKZl98RsetdRi/eZ8eAFLNQ2e9Aq9O45otm+/rAW1 yX4jO1OTt/Jfh5E4A/6fVMgBmSKl6iAnAtjuf/p6y2sJ/T3prQXD5lnOFjrQKPdCX2WFp97W30U +HNnk65x/It6Jj/Fw6mHIkntA0+xC7cCHcEQdG4C5iIZZ6hbwptjOaYKL X-Gm-Gg: ASbGncvVqsfX2w58YU2QdQ25OjEZnC0N0OjEKmKcDkpNz+sofPQ+zWdcuj9PZQrowVv v+WVJglErGorxq/1hp8d/lE3LlIW+zEBjuxg2g3uoI1jpgHtSCaKyZCZHVZi8Rc1akwjGMVgfh+ kNZ0Q9SbjEuuNmZBqTSlDEzZKXzPkMqrwmuqxHWpISmPN7wfNlFbp2LeWx1Nvx8gOLtuarkz9AK g5sDTkj4YDFOCl0BaangU7pryldCq4lwyOaJrUW+CR0dLHYCRGcTnhm74QYr2reyKRu4Ry/uJ14 5/XOsJlKwLkVAxvCSI2JVDjdqLqhO/yFrQS108gibt7aL1C04Z2GkGoI+kJGb/Kq0iwDzGWbmZW skjuLMxyKsFTI5aECdPRXq0X/re415NIdEoz0JqonOjmNvb29+N55yWEw1Q== X-Received: by 2002:a05:622a:1243:b0:4ee:9b1:e2a with SMTP id d75a77b69052e-4f1b1a6d070mr42643751cf.23.1765383492104; Wed, 10 Dec 2025 08:18:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwlVZk7OOsEi+9V68yIVGvOGC66xTxpglSJpR+cQpJu+j4T74KFxE5DoQP+ed01yYiVnjWqg== X-Received: by 2002:a05:622a:1243:b0:4ee:9b1:e2a with SMTP id d75a77b69052e-4f1b1a6d070mr42643171cf.23.1765383491687; Wed, 10 Dec 2025 08:18:11 -0800 (PST) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f027d586e8sm118166291cf.33.2025.12.10.08.18.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 08:18:11 -0800 (PST) Message-ID: <9bafd2ea-96b6-44ba-b0fa-d2c6075eea6a@redhat.com> Date: Wed, 10 Dec 2025 17:18:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable accelerated SMMUv3 Content-Language: en-US To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Shameer Kolothum , "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" Cc: "peter.maydell@linaro.org" , Jason Gunthorpe , Nicolin Chen , "ddutile@redhat.com" , "berrange@redhat.com" , Nathan Chen , Matt Ochs , "smostafa@google.com" , "wangzhou1@hisilicon.com" , "jiangkunkun@huawei.com" , "jonathan.cameron@huawei.com" , "zhangfei.gao@linaro.org" , "zhenzhong.duan@intel.com" , "yi.l.liu@intel.com" , Krishnakant Jaju References: <20251120132213.56581-1-skolothumtho@nvidia.com> <1ee20ead-6978-4c2b-9b2f-ad778107ad04@redhat.com> From: Eric Auger In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/10/25 5:07 PM, Cédric Le Goater wrote: > On 12/10/25 16:07, Shameer Kolothum wrote: >> >> >>> -----Original Message----- >>> From: Cédric Le Goater >>> Sent: 09 December 2025 10:32 >>> To: Shameer Kolothum ; qemu- >>> arm@nongnu.org; qemu-devel@nongnu.org >>> Cc: eric.auger@redhat.com; peter.maydell@linaro.org; Jason Gunthorpe >>> ; Nicolin Chen ; >>> ddutile@redhat.com; berrange@redhat.com; Nathan Chen >>> ; Matt Ochs ; >>> smostafa@google.com; wangzhou1@hisilicon.com; >>> jiangkunkun@huawei.com; jonathan.cameron@huawei.com; >>> zhangfei.gao@linaro.org; zhenzhong.duan@intel.com; yi.l.liu@intel.com; >>> Krishnakant Jaju >>> Subject: Re: [PATCH v6 00/33] hw/arm/virt: Add support for >>> user-creatable >>> accelerated SMMUv3 >>> >> [...] >> >>> >>> FYI, I am seeing configure errors : >>> >>> The following clauses were found for ARM_SMMUV3_ACCEL >>>       select ARM_SMMUV3_ACCEL if ARM_VIRT >>>       config ARM_SMMUV3_ACCEL depends on (ARM_SMMUV3 && IOMMUFD) >> >> -    select ARM_SMMUV3_ACCEL >> +    imply  ARM_SMMUV3_ACCEL >> >> the above will fix it? > > No. I would propose : > > @@ -12,7 +12,6 @@ config ARM_VIRT >      select ARM_GIC >      select ACPI >      select ARM_SMMUV3 > -    select ARM_SMMUV3_ACCEL >      select GPIO_KEY >      select DEVICE_TREE >      select FW_CFG_DMA > @@ -627,12 +626,13 @@ config FSL_IMX8MP_EVK >      depends on TCG >      select FSL_IMX8MP >   > -config ARM_SMMUV3 > +config ARM_SMMUV3_ACCEL >      bool > +    depends on ARM_SMMUV3 >   > -config ARM_SMMUV3_ACCEL > +config ARM_SMMUV3 >      bool > -    depends on ARM_SMMUV3 && IOMMUFD > +    select ARM_SMMUV3_ACCEL if IOMMUFD  Zhenzhong has a variant in https://lore.kernel.org/all/20251117093729.1121324-10-zhenzhong.duan@intel.com/ I guess it also works Eric >   >  config FSL_IMX6UL >      bool > >>> >>> KconfigDataError: contradiction between clauses when setting >>> ARM_SMMUV3_ACCEL >> >> Just curious, how to trigger these errors easily? Any scripts? > Try the windows build : > >   ../configure --cross-prefix=x86_64-w64-mingw32- \ >     --disable-sdl \ >     --prefix=/path/to/install-mingw64 \ >     > --target-list=aarch64-softmmu,ppc64-softmmu,x86_64-softmmu,s390x-softmmu > \ >     --disable-docs > > problems such as : > > ../hw/arm/smmuv3-accel.h:14:10: fatal error: linux/iommufd.h: No such > file or directory >    14 | #include >       |          ^~~~~~~~~~~~~~~~~ > > should be fixed too. > > Thanks, > > C. >