From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org, armbru@redhat.com
Cc: famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 00/26] qapi: QMP dispatch and input visitor work
Date: Tue, 28 Feb 2017 12:40:22 -0600 [thread overview]
Message-ID: <9bccf145-9481-2eee-dabb-33001071a841@redhat.com> (raw)
In-Reply-To: <148830500441.258.8927797894103383324@0e2666bad730>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On 02/28/2017 12:03 PM, no-reply@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Checking PATCH 18/26: tests-qobject-input-strict: Merge into test-qobject-input-visitor...
> ERROR: line over 90 characters
> #486: FILE: tests/test-qobject-input-visitor.c:847:
> + v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo', 'extra': 42 }");
Code motion, can be ignored (we may want to clean it up later, but
doesn't affect this series).
> Checking PATCH 24/26: tests: Cover input visit beyond end of list...
> ERROR: if this code is redundant consider removing it
> #85: FILE: tests/test-qobject-input-visitor.c:956:
> +#if 0 /* FIXME crash */
Fixed later in the series, so doesn't impact the overall submission.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-02-28 18:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 17:38 [Qemu-devel] [PATCH v3 00/26] qapi: QMP dispatch and input visitor work Markus Armbruster
2017-02-28 17:38 ` [Qemu-devel] [PATCH v3 01/26] qga: Fix crash on non-dictionary QMP argument Markus Armbruster
2017-02-28 17:38 ` [Qemu-devel] [PATCH v3 02/26] libqtest: Work around a "QMP wants a newline" bug Markus Armbruster
2017-02-28 17:38 ` [Qemu-devel] [PATCH v3 03/26] qmp-test: New, covering basic QMP protocol Markus Armbruster
2017-02-28 17:38 ` [Qemu-devel] [PATCH v3 04/26] qmp: Dumb down how we run QMP command registration Markus Armbruster
2017-02-28 17:38 ` [Qemu-devel] [PATCH v3 05/26] qmp: Clean up how we enforce capability negotiation Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 06/26] qmp: Drop duplicated QMP command object checks Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 07/26] qmp: Eliminate silly QERR_QMP_* macros Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 08/26] qmp: Improve QMP dispatch error messages Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 09/26] qapi: Improve a QObject input visitor error message Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 10/26] qapi: Clean up after commit 3d344c2 Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 11/26] qapi: Make QObject input visitor set *list reliably Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 12/26] qapi: Improve qobject input visitor error reporting Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 13/26] qapi: Drop string input visitor method optional() Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 14/26] qapi: Make string input and opts visitor require non-null input Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 15/26] qom: Make object_property_set_qobject()'s input visitor strict Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 16/26] test-qobject-input-visitor: Use strict visitor Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 17/26] qapi: Drop unused non-strict qobject input visitor Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 18/26] tests-qobject-input-strict: Merge into test-qobject-input-visitor Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 19/26] test-string-input-visitor: Tear down existing test automatically Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 20/26] test-string-input-visitor: Improve list coverage Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 21/26] tests: Cover partial input visit of list Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 22/26] test-qobject-input-visitor: Cover missing nested struct member Markus Armbruster
2017-02-28 18:34 ` Eric Blake
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 23/26] qapi: Make input visitors detect unvisited list tails Markus Armbruster
2017-02-28 18:38 ` Eric Blake
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 24/26] tests: Cover input visit beyond end of list Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 25/26] qapi: Fix object " Markus Armbruster
2017-02-28 17:39 ` [Qemu-devel] [PATCH v3 26/26] qapi: Improve qobject visitor documentation Markus Armbruster
2017-02-28 18:03 ` [Qemu-devel] [PATCH v3 00/26] qapi: QMP dispatch and input visitor work no-reply
2017-02-28 18:40 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bccf145-9481-2eee-dabb-33001071a841@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).