From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B53FC32753 for ; Wed, 14 Aug 2019 14:52:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25E7C206C1 for ; Wed, 14 Aug 2019 14:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25E7C206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxudv-0002MJ-7s for qemu-devel@archiver.kernel.org; Wed, 14 Aug 2019 10:52:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35737) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxud6-0001sI-7V for qemu-devel@nongnu.org; Wed, 14 Aug 2019 10:52:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxud5-0006AZ-1F for qemu-devel@nongnu.org; Wed, 14 Aug 2019 10:52:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35522) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxud1-00069W-EF; Wed, 14 Aug 2019 10:51:55 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C074E91772; Wed, 14 Aug 2019 14:51:54 +0000 (UTC) Received: from kinshicho (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBF1E806AD; Wed, 14 Aug 2019 14:51:50 +0000 (UTC) Message-ID: <9becb1b8d13703740411ae0e1e6e0580fe6a1bc7.camel@redhat.com> From: Andrea Bolognani To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , "Richard W . M . Jones" , qemu-devel@nongnu.org, Pino Toscano Date: Wed, 14 Aug 2019 16:51:48 +0200 In-Reply-To: References: <20190814121527.17876-1-philmd@redhat.com> <20190814121527.17876-3-philmd@redhat.com> <4876e26ccda980f45e0ad1492097a66b07fe65de.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 14 Aug 2019 14:51:54 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?Q?=E5=91=A8=E6=96=87=E9=9D=92?= <1151451036@qq.com>, Alex =?ISO-8859-1?Q?Benn=E9e?= , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daud=C3=A9 wrote: > On 8/14/19 3:27 PM, Andrea Bolognani wrote: > > On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daud=C3=A9 wrote: > > > The libssh packaged by a distribution can predate version 0.8, > > > but still provides the newer API introduced after version 0.7. > > >=20 > > > Using the deprecated API leads to build failure, as on Ubuntu 18.04= : > > >=20 > > > CC block/ssh.o > > > block/ssh.c: In function 'check_host_key_hash': > > > block/ssh.c:444:5: error: 'ssh_get_publickey' is deprecated [-Wer= ror=3Ddeprecated-declarations] > > > r =3D ssh_get_publickey(s->session, &pubkey); > > > ^ > > > In file included from block/ssh.c:27:0: > > > /usr/include/libssh/libssh.h:489:31: note: declared here > > > SSH_DEPRECATED LIBSSH_API int ssh_get_publickey(ssh_session sess= ion, ssh_key *key); > > > ^~~~~~~~~~~~~~~~~ > > > rules.mak:69: recipe for target 'block/ssh.o' failed > > > make: *** [block/ssh.o] Error 1 > > >=20 > > > Fix by using the newer API if available. > > >=20 > > > Suggested-by: Andrea Bolognani > > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > > --- > > > block/ssh.c | 2 +- > > > configure | 7 +++++++ > > > 2 files changed, 8 insertions(+), 1 deletion(-) > >=20 > > Did I really suggest this? I have no recollection of doing so, or > > even getting involved with libssh support in QEMU at all for that > > matter. >=20 > I took this suggestion from > https://www.redhat.com/archives/libvir-list/2018-May/msg00597.html I see :) I feel like adding a Suggested-by because of something that was posted on an unrelated project's mailing list is stretching the definition of the tag a bit, so if you end up having to respin I think it would be reasonable to drop it, but honestly it's not a big deal either way: I was just curious. --=20 Andrea Bolognani / Red Hat / Virtualization