From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53483)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1buEfR-0001VY-8l
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:13:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1buEfM-0000Hd-Rw
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:13:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1buEfM-0000HZ-Ky
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:13:32 -0400
References: <1476251888-20238-1-git-send-email-ppandit@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <9becea85-2bd3-98be-431c-e20e4a1ab0ec@redhat.com>
Date: Wed, 12 Oct 2016 10:13:27 +0200
MIME-Version: 1.0
In-Reply-To: <1476251888-20238-1-git-send-email-ppandit@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] char: serial: check divider value
 against baud base
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: P J P <ppandit@redhat.com>, Qemu Developers <qemu-devel@nongnu.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Huawei PSIRT <psirt@huawei.com>, Prasad J Pandit <pjp@fedoraproject.org>



On 12/10/2016 07:58, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
> 
> 16550A UART device uses an oscillator to generate frequencies
> (baud base), which decide communication speed. This speed could
> be changed by dividing it by a divider. If the divider is
> greater than the baud base, speed is set to zero, leading to a
> divide by zero error. Add check to avoid it.
> 
> Reported-by: Huawei PSIRT <psirt@huawei.com>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
>  hw/char/serial.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Update per
>   -> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg02400.html
> 
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index 3442f47..eec72b7 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -153,8 +153,9 @@ static void serial_update_parameters(SerialState *s)
>      int speed, parity, data_bits, stop_bits, frame_size;
>      QEMUSerialSetParams ssp;
>  
> -    if (s->divider == 0)
> +    if (s->divider == 0 || s->divider > s->baudbase) {
>          return;
> +    }
>  
>      /* Start bit. */
>      frame_size = 1;
> 

Queued, thanks.

Paolo