From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/5] coccinelle: use DIV_ROUND_UP
Date: Wed, 7 Jun 2017 16:50:23 -0500 [thread overview]
Message-ID: <9bf29800-aecc-aeca-44d2-7a208fcc602f@redhat.com> (raw)
In-Reply-To: <20170607074632.13162-3-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On 06/07/2017 02:46 AM, Marc-André Lureau wrote:
> The coccinelle/round.cocci script doesn't catch hard coded values.
>
> I used the following script over qemu code base:
>
> (
> - ((e1) + 3) / (4)
> + DIV_ROUND_UP(e1,4)
As in 1/5, can't you also write a search for ((e1) + (e2) - 1) / e2, to
cover non-constant divisions?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-06-07 21:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 7:46 [Qemu-devel] [PATCH 0/5] Code cleanups with Coccinelle Marc-André Lureau
2017-06-07 7:46 ` [Qemu-devel] [PATCH 1/5] coccinelle: replace code with ROUND_UP macro Marc-André Lureau
2017-06-07 10:01 ` Juan Quintela
2017-06-07 21:48 ` Eric Blake
2017-06-07 7:46 ` [Qemu-devel] [PATCH 2/5] coccinelle: use DIV_ROUND_UP Marc-André Lureau
2017-06-07 9:13 ` Peter Maydell
2017-06-07 9:27 ` Marc-André Lureau
2017-06-07 21:50 ` Eric Blake [this message]
2017-06-08 7:37 ` Marc-André Lureau
2017-06-07 7:46 ` [Qemu-devel] [PATCH 3/5] arch: introduce ELF_NOTE_SIZE macro Marc-André Lureau
2017-06-07 7:46 ` [Qemu-devel] [PATCH 4/5] Replace g_malloc()+memcpy() with g_memdup() Marc-André Lureau
2017-06-07 10:02 ` Juan Quintela
2017-06-07 7:46 ` [Qemu-devel] [PATCH 5/5] coccinelle: prefer glib g_new/g_renew macros Marc-André Lureau
2017-06-07 21:58 ` Eric Blake
2017-06-08 8:23 ` Marc-André Lureau
2017-06-08 8:50 ` Markus Armbruster
2017-06-08 20:15 ` Eric Blake
2017-06-08 20:11 ` Eric Blake
2017-06-07 17:21 ` [Qemu-devel] [PATCH 0/5] Code cleanups with Coccinelle no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf29800-aecc-aeca-44d2-7a208fcc602f@redhat.com \
--to=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).