Re: [PATCH] tests/vm: do not specify -bios option

[Paolo Bonzini <pbonzini@redhat.com>]

On 6/16/22 10:44, Daniel P. Berrangé wrote:
> On Thu, Jun 16, 2022 at 10:30:25AM +0200, Paolo Bonzini wrote:
>> When running from the build tree, the executable is able to find
>> the BIOS on its own; when running from the source tree, a firmware
>> blob should already be installed and there is no guarantee that
>> the one in the source tree works with the QEMU that is being used for
>> the installation.
> I think there is interaction with
> 
>    --firmwarepath=/usr/share/qemu-firmware:/usr/share/ipxe/qemu:/usr/share/seavgabios:/usr/share/seabios:/usr/share/sgabios
> 
> as the firmware path listed there will be searched before the local
> build tree.
> 
> I agree with your desire to remove the -bios option, but I'm not
> sure it is entirely safe unless logic in qemu_find_file is fixed
> to ignore the global search path when running from the build
> tree.

Isn't this the same for any other invocation of QEMU, for example in qtest?

I admit I didn't think of the interaction with --firmwarepath, but "if 
it hurts, don't do it" might apply here.  That is, install compatible 
firmware to the path _before_ trying to use a QEMU that specifies that path.

Thanks,

Paolo