From: Michal Privoznik <mprivozn@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/5] pr-manager-helper: avoid SIGSEGV when writing to the socket fail
Date: Tue, 26 Jun 2018 18:24:59 +0200 [thread overview]
Message-ID: <9bffdc65-6199-f487-88f1-b14d2ae99636@redhat.com> (raw)
In-Reply-To: <20180626154028.11133-4-pbonzini@redhat.com>
On 06/26/2018 05:40 PM, Paolo Bonzini wrote:
> When writing to the qemu-pr-helper socket failed, the persistent
> reservation manager was correctly disconnecting the socket, but it
> did not clear pr_mgr->ioc. So the rest of the code did not know
> that the socket had been disconnected, accessed pr_mgr->ioc and
> happily caused a crash.
>
> To reproduce, it is enough to stop qemu-pr-helper between QEMU
> startup and executing e.g. sg_persist -k /dev/sdb.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scsi/pr-manager-helper.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal
next prev parent reply other threads:[~2018-06-26 16:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 15:40 [Qemu-devel] [PATCH 0/5] pr-manager/qemu-pr-helper patches for QEMU 3.0 Paolo Bonzini
2018-06-26 15:40 ` [Qemu-devel] [PATCH 1/5] pr-helper: fix --socket-path default in help Paolo Bonzini
2018-06-26 16:13 ` Philippe Mathieu-Daudé
2018-06-26 16:24 ` Michal Privoznik
2018-06-26 15:40 ` [Qemu-devel] [PATCH 2/5] pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN Paolo Bonzini
2018-06-26 16:16 ` Philippe Mathieu-Daudé
2018-06-26 16:25 ` Michal Privoznik
2018-06-26 15:40 ` [Qemu-devel] [PATCH 3/5] pr-manager-helper: avoid SIGSEGV when writing to the socket fail Paolo Bonzini
2018-06-26 16:24 ` Michal Privoznik [this message]
2018-06-26 15:40 ` [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command Paolo Bonzini
2018-06-26 16:31 ` Michal Privoznik
2018-06-27 15:44 ` Paolo Bonzini
2018-06-28 7:05 ` Michal Prívozník
2018-06-28 7:08 ` Paolo Bonzini
2018-06-26 20:51 ` Eric Blake
2018-06-27 15:34 ` Paolo Bonzini
2018-06-26 15:40 ` [Qemu-devel] [PATCH 5/5] pr-manager-helper: report event on connection/disconnection Paolo Bonzini
2018-06-26 16:23 ` Philippe Mathieu-Daudé
2018-06-27 8:04 ` Michal Privoznik
2018-06-27 10:16 ` Michal Privoznik
2018-06-27 15:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bffdc65-6199-f487-88f1-b14d2ae99636@redhat.com \
--to=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).