From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4531DC52D71 for ; Fri, 2 Aug 2024 06:49:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZm6D-0004YF-Ps; Fri, 02 Aug 2024 02:49:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZm6B-0004UG-LY for qemu-devel@nongnu.org; Fri, 02 Aug 2024 02:49:11 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZm69-0000Cy-U1 for qemu-devel@nongnu.org; Fri, 02 Aug 2024 02:49:11 -0400 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2cb55ff1007so5280363a91.0 for ; Thu, 01 Aug 2024 23:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722581348; x=1723186148; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1XT25LlmPDhPO2b7/0lbnD/fY7z8TW6QtI0bYE+GIck=; b=VvQsTpZHxBr6miBMSCEiM4USw7akp/whm2gcLSbVReX1/8193KOQV2ny9UrcFIK3cX 6721qMYPEuztF29xFOQw1QfbTXGv4hf3/JmqTSIAmNrurJVbeYLUrxIBb/RhF08PJm/P UfVYRNi/DBkAv3uMn9EsyTd/NVvKe5eD6czw+lTApYNAckDOZU/hNKzQR3am3y2o2AFc 2Alq52lfWImDgeueH2yel+IXjSxdhPbjiyraUSeXzWzbk/8tWktYqWf64Xd0x1ihwzQU BQN87DDfl2gGwP0iojOV/EdUTGa9yASY0Gx1c8BAuv4EYmdzxYw/2Rt5FA/UBk9u03/o gaaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722581348; x=1723186148; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1XT25LlmPDhPO2b7/0lbnD/fY7z8TW6QtI0bYE+GIck=; b=mhOkpSyyUV70AxkgXm3Jqmg97iSTxkUxvbTYcVNKyG68tKhgYAe6sXZAWIOj8RUryJ zzr5NlsA0zpn8uQZhm9xVghmaRbLWqkBG4iL7cW62H8FPExW8NqBXNZKM8z/VM4mFpeD NpeHPUmKcGIgeSmDEQaOV7QhYxxmj4LYHDJkvqtfnxWCQGnpETGIzq1J/fWq1ZMo+0vG PSZXJ9VW6WFjCTe1PPv3r9dUFrwRkxRcz3eVl2Hix3TlRBtq4SB7/Z/wXCpd8v0q8r5M //lBwIDixOQfr6IkE7HKPc4J5Y8SBDNyhtGGWsn0QFRY0OqzRyto9iigMMxKZGt7Nfdd 0+qw== X-Forwarded-Encrypted: i=1; AJvYcCVCDvtYby786GNsB/9woMrUQwoN27efE42lEPexpgvg1Aff+0MKVZoZN/U4+Pw9G9H9UfLjRrSBDkVS@nongnu.org X-Gm-Message-State: AOJu0YyZgakYgCweOgFpkmXI2C2VyawmHWb3N8PWAKhKU6n4JbSwcsEd Ro9YmI/U6GSqeng8USJvsNeoF0vAru9IMno4RFFZOwsZ9uCgYq+bh9P50B4If7s= X-Google-Smtp-Source: AGHT+IFy/ilY73Qlg0jeTTPW7kOWnWvsHUgAm5sC1gjPyRsStDpvWdFsZ9ittRnd/0aDlthqAb9FMA== X-Received: by 2002:a17:90b:194c:b0:2c9:6f03:6fd6 with SMTP id 98e67ed59e1d1-2cff941b383mr3217398a91.17.1722581348348; Thu, 01 Aug 2024 23:49:08 -0700 (PDT) Received: from [192.168.1.113] ([203.56.128.103]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cfca29fd5dsm4651093a91.0.2024.08.01.23.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 23:49:07 -0700 (PDT) Message-ID: <9c090b8a-24d5-4bec-84e1-be59e4faa55a@linaro.org> Date: Fri, 2 Aug 2024 16:49:01 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] target/riscv: Relax fld alignment requirement To: LIU Zhiwei , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, palmer@dabbelt.com, alistair.francis@wdc.com, dbarboza@ventanamicro.com, liwei1518@gmail.com, bmeng.cn@gmail.com References: <20240802031612.604-1-zhiwei_liu@linux.alibaba.com> <20240802031612.604-4-zhiwei_liu@linux.alibaba.com> <05d5a772-a7b9-4bfd-8ca0-f85dcf2d1505@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/2/24 16:27, LIU Zhiwei wrote: >> Does this really have byte atomicity, not atomic on two aligned 32-bit loads (which >> would be MO_ATOM_IFALIGN_PAIR). > The specification doesn't rule it. I think we can choose either way. The byte atomicity > may expose more problems on alignment. Ok. r~