From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1detli-0006eS-UP for qemu-devel@nongnu.org; Mon, 07 Aug 2017 21:57:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1detle-0001IR-9y for qemu-devel@nongnu.org; Mon, 07 Aug 2017 21:57:15 -0400 References: <1502117160-24655-1-git-send-email-armbru@redhat.com> <1502117160-24655-30-git-send-email-armbru@redhat.com> From: John Snow Message-ID: <9c09b2bd-50e9-b354-8c67-c965d57dfef4@redhat.com> Date: Mon, 7 Aug 2017 21:56:51 -0400 MIME-Version: 1.0 In-Reply-To: <1502117160-24655-30-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 29/56] block: Make BlockDirtyInfo byte count unsigned in QAPI/QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, jcody@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com On 08/07/2017 10:45 AM, Markus Armbruster wrote: > Byte counts should use QAPI type 'size' (uint64_t). BlockDirtyInfo > member @count is 'int' (int64_t). bdrv_query_dirty_bitmaps() computes > @count from bdrv_get_dirty_count() in uint64_t, then implicitly > converts to int64_t. Before the commit before previous, the > conversion was in bdrv_get_dirty_count() instead. > > Change member @count to 'size'. > > query-block now reports @count values above 2^63-1 correctly instead > of their (negative) two's complement. > > Signed-off-by: Markus Armbruster Assuming there's no "gotcha" here introduced by changing the QAPI, then ACK; but you're the expert there, so I trust you! Reviewed-by: John Snow