From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/7] tcg/tcg-op: Document bswap32() byte pattern
Date: Wed, 23 Aug 2023 08:54:04 -0700 [thread overview]
Message-ID: <9c1329b2-83f4-c9e1-6a64-7d78c0cfef55@linaro.org> (raw)
In-Reply-To: <6d4f5e8c-82ae-4396-3c4e-fe0bfd721341@linaro.org>
On 8/23/23 06:14, Philippe Mathieu-Daudé wrote:
> On 22/8/23 18:00, Richard Henderson wrote:
>> On 8/22/23 02:37, Philippe Mathieu-Daudé wrote:
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>> tcg/tcg-op.c | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>
>
>>> +/*
>>> + * bswap32_i64: 32-bit byte swap on the low bits of a 64-bit value.
>>> + *
>>> + * Byte pattern: bswap32_i64(xxxxabcd) -> ....dcba (TCG_BSWAP_OZ)
>>> + * bswap32_i64(xxxxabcd) -> ssssdcba (TCG_BSWAP_OS)
>>> + * bswap32_i64(xxxxabcd) -> xxxxdcba
>>> + */
>>
>> Again, TCG_BSWAP_IZ.
>
> Whether TCG_BSWAP_IZ is set or not doesn't change the result, at the
> end we have:
>
> bswap32_i64(xxxxabcd) -> ....dcba (TCG_BSWAP_OS not set)
> bswap32_i64(xxxxabcd) -> ssssdcba (TCG_BSWAP_OS set)
It changes the input: not 'x' but '.'.
r~
next prev parent reply other threads:[~2023-08-23 15:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 9:37 [PATCH 0/7] tcg: Document *swap/deposit helpers Philippe Mathieu-Daudé
2023-08-22 9:37 ` [PATCH 1/7] tcg/tcg-op: Document bswap16() byte pattern Philippe Mathieu-Daudé
2023-08-22 15:58 ` Richard Henderson
2023-08-22 17:22 ` Philippe Mathieu-Daudé
2023-08-22 17:29 ` Richard Henderson
2023-08-22 22:04 ` Philippe Mathieu-Daudé
2023-08-22 9:37 ` [PATCH 2/7] tcg/tcg-op: Document bswap32() " Philippe Mathieu-Daudé
2023-08-22 16:00 ` Richard Henderson
2023-08-23 13:14 ` Philippe Mathieu-Daudé
2023-08-23 15:54 ` Richard Henderson [this message]
2023-08-22 9:37 ` [PATCH 3/7] tcg/tcg-op: Document bswap64() " Philippe Mathieu-Daudé
2023-08-22 16:00 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 4/7] tcg/tcg-op: Document hswap() " Philippe Mathieu-Daudé
2023-08-22 16:02 ` Richard Henderson
2023-08-22 16:04 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 5/7] tcg/tcg-op: Document wswap() " Philippe Mathieu-Daudé
2023-08-22 16:03 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 6/7] tcg/tcg-op: Document deposit_z() Philippe Mathieu-Daudé
2023-08-22 16:05 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 7/7] target/cris: Fix a typo in gen_swapr() Philippe Mathieu-Daudé
2023-08-22 13:42 ` [PATCH 0/7] tcg: Document *swap/deposit helpers Alex Bennée
2023-08-22 13:58 ` Peter Maydell
2023-08-22 14:43 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1329b2-83f4-c9e1-6a64-7d78c0cfef55@linaro.org \
--to=richard.henderson@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).