From: Richard Henderson <richard.henderson@linaro.org>
To: "Víctor Colombo" <victor.colombo@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: groug@kaod.org, danielhb413@gmail.com, clg@kaod.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH 00/20] target/ppc: Remove hidden usages of *env
Date: Tue, 26 Apr 2022 13:55:42 -0700 [thread overview]
Message-ID: <9c477785-4f5e-1fe9-26e4-d8ea4b15c569@linaro.org> (raw)
In-Reply-To: <20220422185450.107256-1-victor.colombo@eldorado.org.br>
On 4/22/22 11:54, Víctor Colombo wrote:
> By running the grep command `git grep -nr 'define \(fpscr\|msr\)_[a-z0-9]\+\>'`
> we can find multiple macros that use `env->fpscr` and `env->msr` but doesn't
> take *env as a parameter.
>
> Richard Henderson said [1] that these macros hiding the usage of *env "are evil".
> This patch series remove them and substitute with an explicit usage of *env by
> adding macros in the same style of FP_* ones (e.g. FP_FI defined in cpu.h).
>
> Patch 20 (target/ppc: Add unused M_MSR_* macros) implements unused macros, the
> same that were removed in patch 02 (target/ppc: Remove unused msr_* macros). I
> did that to keep the changes consistent with what was already present before.
Oh frabjous day! Callooh! Callay!
r~
prev parent reply other threads:[~2022-04-26 20:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 18:54 [PATCH 00/20] target/ppc: Remove hidden usages of *env Víctor Colombo
2022-04-22 18:54 ` [PATCH 01/20] target/ppc: Remove fpscr_* macros from cpu.h Víctor Colombo
2022-04-26 21:11 ` Richard Henderson
2022-04-22 18:54 ` [PATCH 02/20] target/ppc: Remove unused msr_* macros Víctor Colombo
2022-04-26 21:11 ` Richard Henderson
2022-04-22 18:54 ` [PATCH 03/20] target/ppc: Substitute msr_pr macro with new M_MSR_PR macro Víctor Colombo
2022-04-26 21:29 ` Richard Henderson
2022-04-27 17:00 ` Víctor Colombo
2022-04-28 6:46 ` Cédric Le Goater
2022-04-28 14:56 ` Víctor Colombo
2022-04-28 15:33 ` Richard Henderson
2022-04-28 21:45 ` BALATON Zoltan
2022-04-22 18:54 ` [PATCH 04/20] target/ppc: Substitute msr_le macro with new M_MSR_LE macro Víctor Colombo
2022-04-23 10:05 ` BALATON Zoltan
2022-04-22 18:54 ` [PATCH 05/20] target/ppc: Substitute msr_ds macro with new M_MSR_DS macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 06/20] target/ppc: Substitute msr_ile macro with new M_MSR_ILE macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 07/20] target/ppc: Substitute msr_ee macro with new M_MSR_EE macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 08/20] target/ppc: Substitute msr_ce macro with new M_MSR_CE macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 09/20] target/ppc: Substitute msr_pow macro with new M_MSR_POW macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 10/20] target/ppc: Substitute msr_me macro with new M_MSR_ME macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 11/20] target/ppc: Substitute msr_gs macro with new M_MSR_GS macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 12/20] target/ppc: Substitute msr_fp macro with new M_MSR_FP macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 13/20] target/ppc: Substitute msr_cm macro with new M_MSR_CM macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 14/20] target/ppc: Substitute msr_ir macro with new M_MSR_IR macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 15/20] target/ppc: Substitute msr_dr macro with new M_MSR_DR macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 16/20] target/ppc: Substitute msr_ep macro with new M_MSR_EP macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 17/20] target/ppc: Substitute msr_fe macro with new M_MSR_FE macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 18/20] target/ppc: Substitute msr_ts macro with new M_MSR_TS macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 19/20] target/ppc: Substitute msr_hv macro with new M_MSR_HV macro Víctor Colombo
2022-04-22 18:54 ` [PATCH 20/20] target/ppc: Add unused M_MSR_* macros Víctor Colombo
2022-04-26 20:55 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c477785-4f5e-1fe9-26e4-d8ea4b15c569@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=victor.colombo@eldorado.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).