From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: pbonzini@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH] nbd/server: fix space read
Date: Mon, 5 Mar 2018 13:56:18 -0600 [thread overview]
Message-ID: <9c4b48b2-e4ad-b8ec-0886-e30d06a950e3@redhat.com> (raw)
In-Reply-To: <b8324efe-7fd4-3c44-faac-a7a9e9e1ad3e@redhat.com>
On 03/05/2018 01:47 PM, Eric Blake wrote:
> On 03/05/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote:
In the subject line: s/space/sparse/
>> In case of io error in nbd_co_send_sparse_read we should not
>> "goto reply:", as it is fatal error and common behavior is
>> disconnect in this case. We should not try to send client an
>> error reply, representing channel-io error on previous try to
>> send a reply.
>
> Good catch.
>
>>
>> Fix this by handle block-status error in nbd_co_send_sparse_read,
>> so nbd_co_send_sparse_read fails only on io error. Then just skip
>> common "reply:" code path in nbd_trip.
>>
>> Note: nbd_co_send_structured_error is moved without changes to be
>> called from nbd_co_send_sparse_read.
>
> Might be easier to read as two patches, one for the code motion, the
> other for using the new code. But I'm not going to insist on a split.
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-05 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 18:04 [Qemu-devel] [PATCH] nbd/server: fix space read Vladimir Sementsov-Ogievskiy
2018-03-05 19:47 ` Eric Blake
2018-03-05 19:56 ` Eric Blake [this message]
2018-03-08 11:50 ` Vladimir Sementsov-Ogievskiy
2018-03-08 15:17 ` Vladimir Sementsov-Ogievskiy
2018-03-08 15:20 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c4b48b2-e4ad-b8ec-0886-e30d06a950e3@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).