From: Thomas Huth <thuth@redhat.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>
Subject: Re: [PATCH v4] kconfig: Add PCIe devices to s390x machines
Date: Wed, 12 Jul 2023 14:57:51 +0200 [thread overview]
Message-ID: <9c4b7232-d8ce-fa76-fd85-e800dce89974@redhat.com> (raw)
In-Reply-To: <20230712121131.130172-2-pbonzini@redhat.com>
On 12/07/2023 14.11, Paolo Bonzini wrote:
>> diff --git a/configs/devices/s390x-softmmu/default.mak b/configs/devices/s390x-softmmu/default.mak
>> index f2287a133f36..2d5ff476e32a 100644
>> --- a/configs/devices/s390x-softmmu/default.mak
>> +++ b/configs/devices/s390x-softmmu/default.mak
>> @@ -7,6 +7,7 @@
>> #CONFIG_VFIO_CCW=n
>> #CONFIG_VIRTIO_PCI=n
>> #CONFIG_WDT_DIAG288=n
>> +#CONFIG_PCIE_DEVICE=n
>
> Should be CONFIG_PCIE_DEVICES; fixed and queued, thanks.
I think the patch is fine for now, but in the long run, I think we should
make sure to mark PCIe-only devices only with PCIE_DEVICES, as Philippe
suggested. So PCIe devices will then also not show up any more on targets
that only provide a plain PCI bus (like hppa, I guess?).
Thomas
next prev parent reply other threads:[~2023-07-12 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 8:01 [PATCH v4] kconfig: Add PCIe devices to s390x machines Cédric Le Goater
2023-07-12 10:48 ` Philippe Mathieu-Daudé
2023-07-12 17:03 ` Cédric Le Goater
2023-07-12 22:23 ` Akihiko Odaki
2023-07-12 12:11 ` Paolo Bonzini
2023-07-12 12:57 ` Thomas Huth [this message]
2023-07-12 15:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c4b7232-d8ce-fa76-fd85-e800dce89974@redhat.com \
--to=thuth@redhat.com \
--cc=clg@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).