From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 3/4] target/arm: Restore M-profile CONTROL.SPSEL before any tailchaining
Date: Fri, 20 Jul 2018 09:19:14 -0700 [thread overview]
Message-ID: <9c56c0d5-3b29-7d3c-607c-f1cecd2077ca@linaro.org> (raw)
In-Reply-To: <20180720145647.8810-4-peter.maydell@linaro.org>
On 07/20/2018 07:56 AM, Peter Maydell wrote:
> On exception return for M-profile, we must restore the CONTROL.SPSEL
> bit from the EXCRET value before we do any kind of tailchaining,
> including for the derived exceptions on integrity check failures.
> Otherwise we will give the guest an incorrect EXCRET.SPSEL value on
> exception entry for the tailchained exception.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/helper.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-07-20 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 14:56 [Qemu-devel] [PATCH 0/4] target/arm: Implement tailchaining for M profile cores Peter Maydell
2018-07-20 14:56 ` [Qemu-devel] [PATCH 1/4] target/arm: Improve exception-taken logging Peter Maydell
2018-07-20 16:15 ` Richard Henderson
2018-07-21 19:47 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-07-20 14:56 ` [Qemu-devel] [PATCH 2/4] target/arm: Initialize exc_secure correctly in do_v7m_exception_exit() Peter Maydell
2018-07-20 16:17 ` Richard Henderson
2018-07-21 19:48 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-07-20 14:56 ` [Qemu-devel] [PATCH 3/4] target/arm: Restore M-profile CONTROL.SPSEL before any tailchaining Peter Maydell
2018-07-20 16:19 ` Richard Henderson [this message]
2018-07-20 14:56 ` [Qemu-devel] [PATCH 4/4] target/arm: Implement tailchaining for M profile cores Peter Maydell
2018-07-20 16:22 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c56c0d5-3b29-7d3c-607c-f1cecd2077ca@linaro.org \
--to=richard.henderson@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).