From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Ani Sinha <ani@anisinha.ca>, qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH] hw/acpi: define PIIX4 acpi pci hotplug property strings at a single place
Date: Mon, 16 Aug 2021 11:21:11 +0200 [thread overview]
Message-ID: <9c755d3e-83b2-8910-236d-9f4d0b122892@redhat.com> (raw)
In-Reply-To: <20210816083214.105740-1-ani@anisinha.ca>
On 8/16/21 10:32 AM, Ani Sinha wrote:
> Now that we have "acpi-pci-hotplug-with-bridge-support" PIIX4 PM property being
> used for both q35 and i440fx machine types, it is better that we defined this
> property string at a single place within a header file like other PIIX4
> properties. We can then use this single definition at all the places that needs
> it instead of duplicating the string everywhere. While at it, this change also
> adds a definition for "acpi-root-pci-hotplug" PIIX4 PM property and uses
> this definition at all places that were formally using the string value.
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> ---
> hw/acpi/ich9.c | 2 +-
> hw/acpi/piix4.c | 4 ++--
> hw/i386/acpi-build.c | 4 ++--
> hw/i386/pc.c | 4 ++--
> hw/i386/pc_q35.c | 2 +-
> include/hw/acpi/acpi.h | 2 ++
> 6 files changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2021-08-16 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 8:32 [PATCH] hw/acpi: define PIIX4 acpi pci hotplug property strings at a single place Ani Sinha
2021-08-16 9:21 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c755d3e-83b2-8910-236d-9f4d0b122892@redhat.com \
--to=philmd@redhat.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).