From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: Re: [RFC PATCH] Makefile: trigger re-configure on updated pythondeps
Date: Thu, 1 Aug 2024 07:19:35 +0200 [thread overview]
Message-ID: <9c8360f9-c15d-4d50-9f30-49c3458a8018@linaro.org> (raw)
In-Reply-To: <20240731140232.22193-1-alex.bennee@linaro.org>
On 31/7/24 16:02, Alex Bennée wrote:
> If we add additional deps for meson we need to ensure we trigger a
> reconfigure to make sure everything is set up.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 02a257584b..0281a883a1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,7 +78,7 @@ x := $(shell rm -rf meson-private meson-info meson-logs)
> endif
>
> # 1. ensure config-host.mak is up-to-date
> -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/VERSION
> +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/pythondeps.toml $(SRC_PATH)/VERSION
This long line could be split with \, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> @echo config-host.mak is out-of-date, running configure
> @if test -f meson-private/coredata.dat; then \
> ./config.status --skip-meson; \
prev parent reply other threads:[~2024-08-01 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 14:02 [RFC PATCH] Makefile: trigger re-configure on updated pythondeps Alex Bennée
2024-07-31 22:13 ` Richard Henderson
2024-08-01 5:19 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c8360f9-c15d-4d50-9f30-49c3458a8018@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).