From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56EBEC369B2 for ; Mon, 14 Apr 2025 14:38:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4Kws-0002c2-2Z; Mon, 14 Apr 2025 10:38:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4KwB-0002Kj-Fu; Mon, 14 Apr 2025 10:37:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4Kw9-0007in-F7; Mon, 14 Apr 2025 10:37:27 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53EAtPMx029154; Mon, 14 Apr 2025 14:37:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=uUF/92 0Gy1eB3qHc8WfUoiozLHC74HB0y+ucYfNvofI=; b=Dt5V6hfw4bcVJKbo74NtJa sGOStjZuV85OjVxFPlFyaiaD/ScUzGK4p7xV4iI5YiZOzuN7Xjm47ZDU+F/VjbdX QNgaKa4pWUoxWRkpdrUeK7KwhJXp2dBhKbpdsMSYklNclmU4ZwuJhKnAObvCofJo +6Dbs+UfDJvAxk7a9TwdTKv3nxDEFUdgyGeMHXdGrHjWklmY5OcbVmc/m4hAj+XU 7m7nKKUs050Kz+MBRO2+bT82DAByRWX+veavhp5VeIM9zlyuHNntmxQOF4Io4zgP Ej+yYmsyF+PD8qbDXIVnyi4E67XRSOziRVMXhX6OFZcmYa4IwNo0sKmwd6JHi4JQ == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 460ndsuqma-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 14:37:21 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53EBLDn0000901; Mon, 14 Apr 2025 14:37:21 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4602vyptfu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 14:37:21 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53EEbKZc22610508 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Apr 2025 14:37:20 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E1F3058059; Mon, 14 Apr 2025 14:37:19 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E22AF58058; Mon, 14 Apr 2025 14:37:18 +0000 (GMT) Received: from [9.61.250.58] (unknown [9.61.250.58]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 14 Apr 2025 14:37:18 +0000 (GMT) Message-ID: <9c837758-c45b-4e08-8cd9-918e25fb1063@linux.ibm.com> Date: Mon, 14 Apr 2025 10:37:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 5/5] s390: implementing CHSC SEI for AP config change To: Thomas Huth , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, borntraeger@linux.ibm.com, alex.williamson@redhat.com, clg@redhat.com, akrowiak@linux.ibm.com References: <20250311151616.98244-1-rreyes@linux.ibm.com> <20250311151616.98244-6-rreyes@linux.ibm.com> Content-Language: en-US From: Rorie Reyes In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: oB-HxwcyNKRy-nhYZ9vjvrG89FegVMJa X-Proofpoint-ORIG-GUID: oB-HxwcyNKRy-nhYZ9vjvrG89FegVMJa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_05,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 mlxscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 mlxlogscore=976 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140105 Received-SPF: pass client-ip=148.163.158.5; envelope-from=rreyes@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/11/25 2:45 AM, Thomas Huth wrote: > #include CONFIG_DEVICES > > at the beginning of the ioinst.c file. Then you should be able to do: > > #ifdef CONFIG_VFIO_AP >     if (s390_has_feat(S390_FEAT_AP)) { >        return ap_chsc_sei_nt0_get_event(res); >     } > #endif This worked > > (or whatever the code should look like). > > Alternatively, and this might even be the nicer variant, add a file > hw/vfio/ap-stub.c and include a dummy ap_chsc_sei_nt0_get_event() > function there. Then in hw/vfio/meson.build add this line: > > vfio_ss.add(when: 'CONFIG_VFIO_AP', if_false: files('ap-stub.c')) This worked as well. Since you mentioned that this is a nicer variant, I'll go with this change. What do you recommend I do for my patches? Should I do an interactive rebase to add the new file hw/vfio/ap-stub.c and updating hw/vfio/meson.build? Or should I make two new commits for each file (ap-stub.c and meson.build)