qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hanna Czenczek <hreitz@redhat.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
	vsementsov@yandex-team.ru, kwolf@redhat.com
Subject: Re: [PATCH v5 4/5] parallels: Replace fprintf by qemu_log in check
Date: Fri, 2 Jun 2023 16:48:34 +0200	[thread overview]
Message-ID: <9c89f136-4ab9-d6bc-e4c4-2dda3505cdff@redhat.com> (raw)
In-Reply-To: <20230529151503.34006-5-alexander.ivanov@virtuozzo.com>

On 29.05.23 17:15, Alexander Ivanov wrote:
> If the check is called during normal work, tracking of the check must be
> present in VM logs to have some clues if something going wrong with user's
> data.

I understand stderr counts as part of the VM log, doesn’t it?  I thought 
stderr is generally logged, and naïvely, it seems like the better fit to 
me, because it conveys more urgency than the standard log (which, 
judging from its callers, looks mostly like a debug log).

Hanna

> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> Reviewed-by: Denis V. Lunev <den@openvz.org>
> ---
>   block/parallels.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)



  reply	other threads:[~2023-06-02 14:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29 15:14 [PATCH v5 0/5] parallels: Add duplication check, repair at open, fix bugs Alexander Ivanov
2023-05-29 15:14 ` [PATCH v5 1/5] parallels: Incorrect data end calculation in parallels_open() Alexander Ivanov
2023-06-02 14:44   ` Hanna Czenczek
2023-05-29 15:15 ` [PATCH v5 2/5] parallels: Split image leak handling to separate check and fix helpers Alexander Ivanov
2023-06-02 14:08   ` Hanna Czenczek
2023-06-05 13:13     ` Alexander Ivanov
2023-05-29 15:15 ` [PATCH v5 3/5] parallels: Add checking and repairing duplicate offsets in BAT Alexander Ivanov
2023-06-02 14:43   ` Hanna Czenczek
2023-06-05 16:55     ` Alexander Ivanov
2023-05-29 15:15 ` [PATCH v5 4/5] parallels: Replace fprintf by qemu_log in check Alexander Ivanov
2023-06-02 14:48   ` Hanna Czenczek [this message]
2023-06-09 10:36     ` Alexander Ivanov
2023-06-09 10:59   ` Peter Maydell
2023-05-29 15:15 ` [PATCH v5 5/5] parallels: Image repairing in parallels_open() Alexander Ivanov
2023-06-02 14:59   ` Hanna Czenczek
2023-06-09 13:21     ` Alexander Ivanov
2023-06-09 13:41       ` Hanna Czenczek
2023-06-11 14:45         ` Alexander Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c89f136-4ab9-d6bc-e4c4-2dda3505cdff@redhat.com \
    --to=hreitz@redhat.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).