Re: [Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge

[Christian Borntraeger <borntraeger@de.ibm.com>]

Looks good to me and is similar to the other devices (e.g. the IPL device)

Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>



On 11/28/2017 02:46 PM, Cornelia Huck wrote:
> Logically, the css bridge should be attached to the machine.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  hw/s390x/css-bridge.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c
> index c4a9735d71..84d33eafc2 100644
> --- a/hw/s390x/css-bridge.c
> +++ b/hw/s390x/css-bridge.c
> @@ -99,6 +99,8 @@ VirtualCssBus *virtual_css_bus_init(void)
> 
>      /* Create bridge device */
>      dev = qdev_create(NULL, TYPE_VIRTUAL_CSS_BRIDGE);
> +    object_property_add_child(qdev_get_machine(), TYPE_VIRTUAL_CSS_BRIDGE,
> +                              OBJECT(dev), NULL);
>      qdev_init_nofail(dev);
> 
>      /* Create bus on bridge device */
>