Re: [Qemu-devel] [PATCH] Add Apollon (OMAP24xx) board support

["Kyungmin Park" <kmpark@infradead.org>]

Hi,

>> @@ -3875,7 +3926,11 @@ static uint32_t omap_sdrc_read(void *opaque, target_phys_addr_t addr)
>>     case 0x68: /* SDRC_DLLB_CTRL */
>>     case 0x6c: /* SDRC_DLLB_STATUS */
>>     case 0x70: /* SDRC_POWER */
>> +         return 0x00;
>> +
>>     case 0x80: /* SDRC_MCFG_0 */
>> +         return 0x4000;
>> +
>
> This should be made writable (default value is 0) and the bootloader
> or the board file (hw/nseries.c) needs to write the correct value
> there.

Agreed, apollon and omap2420h4 read this value at bootloader, Yes it's
meanless in qemu.
it's seted at initial bootloader, but it's not in qemu. If sdrc has
array value, we can read it

>
> Would there be much redundancy if apollon setup was in a separate file?

Yes, as you see almost same as n800.

>
> The latter two don't seem to be supported in this patch. OMAP2 on-chip
> lcdc will require a bit of work to be usable.

It's initial support we need to work more to support full peripherals.
>
>> +@item
>> +Secure Digital card connected to OMAP MMC/SD host
>> +@item
>> +One OMAP on-chip UARTs
>> +@item
>> +External USB transceiver chip connected to USB controller embedded in a TI
>
> (TUSB6010 chip?)

actually ISP1105W.

>
>> +@item
>> +Three GPIO switches and GPIO indicate LEDs
>
> This isn't in the patch either.
>
> I'll commit the omap GPMC improvements for the moment.
>

same as above.

If you don't mind I want to add mentioned devices later

Thank you,
Kyungmin Park