Re: [Qemu-devel] [PATCH] Add Apollon (OMAP24xx) board support

["Kyungmin Park" <kmpark@infradead.org>]

Hi,

>>
>>>
>>> Would there be much redundancy if apollon setup was in a separate file?
>>
>> Yes, as you see almost same as n800.
>
> It seems apollon only uses n8x0_init, n8x0_nand_setup and
> n8x0_usb_setup, everything else is nseries-specific. (plus maybe the
> menelaus chip on i2c)

Okay I will separate apolloc.c

>
>>
>>>
>>> The latter two don't seem to be supported in this patch. OMAP2 on-chip
>>> lcdc will require a bit of work to be usable.
>>
>> It's initial support we need to work more to support full peripherals.
>>>
>>>> +@item
>>>> +Secure Digital card connected to OMAP MMC/SD host
>>>> +@item
>>>> +One OMAP on-chip UARTs
>>>> +@item
>>>> +External USB transceiver chip connected to USB controller embedded in a TI
>>>
>>> (TUSB6010 chip?)
>>
>> actually ISP1105W.
>>
>>>
>>>> +@item
>>>> +Three GPIO switches and GPIO indicate LEDs
>>>
>>> This isn't in the patch either.
>>>
>>> I'll commit the omap GPMC improvements for the moment.
>>>
>>
>> same as above.
>>
>> If you don't mind I want to add mentioned devices later
>
> You don't have to add them, but they shouldn't be listed in
> qemu-doc.texi before they are supported.

How about to add prefix 'TODO'?

I'll send new patch again.

Thank you,
Kyungmin Park