From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNMrM-00045u-3Y for qemu-devel@nongnu.org; Mon, 28 Jul 2008 03:09:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNMrK-00044f-Aq for qemu-devel@nongnu.org; Mon, 28 Jul 2008 03:09:31 -0400 Received: from [199.232.76.173] (port=33938 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNMrK-00044V-5F for qemu-devel@nongnu.org; Mon, 28 Jul 2008 03:09:30 -0400 Received: from mx20.gnu.org ([199.232.41.8]:11779) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KNMrJ-0006CJ-GV for qemu-devel@nongnu.org; Mon, 28 Jul 2008 03:09:29 -0400 Received: from wf-out-1314.google.com ([209.85.200.175]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNMrI-0006r5-8S for qemu-devel@nongnu.org; Mon, 28 Jul 2008 03:09:28 -0400 Received: by wf-out-1314.google.com with SMTP id 27so5554846wfd.4 for ; Mon, 28 Jul 2008 00:09:26 -0700 (PDT) Message-ID: <9c9fda240807280009o1d78afe8ma932ae6b4f6044a8@mail.gmail.com> Date: Mon, 28 Jul 2008 16:09:26 +0900 From: "Kyungmin Park" Sender: kyungmin78@gmail.com Subject: Re: [Qemu-devel] [PATCH] Add Apollon (OMAP24xx) board support In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080724230053.GA20704@july> <9c9fda240807250054o7db36912u3f3d11d0a580a91c@mail.gmail.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, >> >>> >>> Would there be much redundancy if apollon setup was in a separate file? >> >> Yes, as you see almost same as n800. > > It seems apollon only uses n8x0_init, n8x0_nand_setup and > n8x0_usb_setup, everything else is nseries-specific. (plus maybe the > menelaus chip on i2c) Okay I will separate apolloc.c > >> >>> >>> The latter two don't seem to be supported in this patch. OMAP2 on-chip >>> lcdc will require a bit of work to be usable. >> >> It's initial support we need to work more to support full peripherals. >>> >>>> +@item >>>> +Secure Digital card connected to OMAP MMC/SD host >>>> +@item >>>> +One OMAP on-chip UARTs >>>> +@item >>>> +External USB transceiver chip connected to USB controller embedded in a TI >>> >>> (TUSB6010 chip?) >> >> actually ISP1105W. >> >>> >>>> +@item >>>> +Three GPIO switches and GPIO indicate LEDs >>> >>> This isn't in the patch either. >>> >>> I'll commit the omap GPMC improvements for the moment. >>> >> >> same as above. >> >> If you don't mind I want to add mentioned devices later > > You don't have to add them, but they shouldn't be listed in > qemu-doc.texi before they are supported. How about to add prefix 'TODO'? I'll send new patch again. Thank you, Kyungmin Park