From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org, Laurent@vivier.eu
Subject: Re: [PATCH 6/7] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn
Date: Fri, 25 Mar 2022 13:09:23 -0600 [thread overview]
Message-ID: <9ca3c82a-c657-91db-8fcf-4fd14476d91d@linaro.org> (raw)
In-Reply-To: <CAFEAcA_H5u=86Sa4ii86E78ych8Pu9yZx-3fHWf9+E_jsuKfgg@mail.gmail.com>
On 3/25/22 06:16, Peter Maydell wrote:
>> + return -QEMU_ESIGRETURN;
>>
>> badframe:
>> unlock_user_struct(frame, frame_addr, 0);
>
> Don't you also need to return -QEMU_ESIGRETURN in the badframe
> error-handling case? The other guest architecture implementations
> of do_sigreturn seem to do that.
Yep, good catch.
r~
next prev parent reply other threads:[~2022-03-25 19:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 16:00 [PATCH 0/7] linux-user/nios2: Fix clone and sigreturn Richard Henderson
2022-03-20 16:00 ` [PATCH 1/7] linux-user/nios2: Fix clone child return Richard Henderson
2022-03-25 11:49 ` Peter Maydell
2022-03-25 15:33 ` Richard Henderson
2022-03-20 16:00 ` [PATCH 2/7] linux-user/nios2: Drop syscall 0 "workaround" Richard Henderson
2022-03-25 11:50 ` Peter Maydell
2022-03-20 16:00 ` [PATCH 3/7] linux-user/nios2: Adjust error return Richard Henderson
2022-03-25 12:12 ` Peter Maydell
2022-03-25 13:37 ` Peter Maydell
2022-03-25 18:55 ` Richard Henderson
2022-03-20 16:00 ` [PATCH 4/7] linux-user/nios2: Handle special qemu syscall return values Richard Henderson
2022-03-25 12:13 ` Peter Maydell
2022-03-20 16:00 ` [PATCH 5/7] linux-user/nios2: Remove do_sigreturn Richard Henderson
2022-03-25 12:14 ` Peter Maydell
2022-03-20 16:00 ` [PATCH 6/7] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn Richard Henderson
2022-03-25 12:16 ` Peter Maydell
2022-03-25 19:09 ` Richard Henderson [this message]
2022-03-20 16:00 ` [PATCH 7/7] tests/tcg/nios2: Re-enable linux-user tests Richard Henderson
2022-03-25 12:16 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca3c82a-c657-91db-8fcf-4fd14476d91d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).