Re: [PATCH 2/5] iotests: Test 041 does not work on macOS

[Thomas Huth <thuth@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1789 bytes --]

On 18/10/2019 18.19, Max Reitz wrote:
> On 11.10.19 16:50, Thomas Huth wrote:
>> 041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as
>> only supported on these systems.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  tests/qemu-iotests/041 | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
>> index 8568426311..7211f1950a 100755
>> --- a/tests/qemu-iotests/041
>> +++ b/tests/qemu-iotests/041
>> @@ -1123,4 +1123,5 @@ class TestOrphanedSource(iotests.QMPTestCase):
>>  
>>  if __name__ == '__main__':
>>      iotests.main(supported_fmts=['qcow2', 'qed'],
>> -                 supported_protocols=['file'])
>> +                 supported_protocols=['file'],
>> +                 supported_platforms=['linux', 'freebsd', 'openbsd6'])
> 
> Hmm, why not just “openbsd”, or single out macOS as unsupported?  (I
> suppose the latter would require an additional patch.)

Ah, right, John's patch uses "startswith(x)", so just using 'openbsd'
should work fine, too. (I initially thought that I have to use the exact
string here)

> There’s also the fact that I maybe wanted to let make check skip all
> tests on macOS and Windows – though that doesn’t make this patch
> unnecessary, because that would only fix make check, not running the
> iotests explicitly.
> 
> And I suppose maybe we even want to run the tests in macOS if it’s part
> of the CI anyway?

At least the current set of tests in the "auto" group works fine on
macOS (running on Cirrus-CI and Travis), so I think we should keep it
enabled in the CI for now (until it creates too much trouble and nobody
is able to debug it ... but we're not at that point yet).

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]