From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24F47E77170 for ; Thu, 5 Dec 2024 18:47:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJGsS-0000iT-Sj; Thu, 05 Dec 2024 13:47:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJGsR-0000hd-7d for qemu-devel@nongnu.org; Thu, 05 Dec 2024 13:47:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJGsN-0007z1-OY for qemu-devel@nongnu.org; Thu, 05 Dec 2024 13:47:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733424417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xcpz8nXLGwmC9vZDFAe3HAaWzF6qmVFTKeo9sRmtICs=; b=OQqHuqhV+7PlNLI6vuF45eKKi9zVeQenisKyd2xy88QzoM2ZmNB3v5ng+xyyCsPOOS0nNb u+dpWC7NWHNe/jG7EZ60iHzC5XfnQt3OBHnEmbARFzCCo05afCDIIVf3gBax/2PW2J7CcP /I6Z32TUcOg5M5rznV3gz33fTTjCaQ8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-U5wv3l2BOMyGoD-Lhb-V4A-1; Thu, 05 Dec 2024 13:46:55 -0500 X-MC-Unique: U5wv3l2BOMyGoD-Lhb-V4A-1 X-Mimecast-MFC-AGG-ID: U5wv3l2BOMyGoD-Lhb-V4A Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7b674755f8eso333774685a.2 for ; Thu, 05 Dec 2024 10:46:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733424415; x=1734029215; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xcpz8nXLGwmC9vZDFAe3HAaWzF6qmVFTKeo9sRmtICs=; b=iRdVpp48jrChkce2XuEqMvRRuDk/7138dasH6PST6hK/dGDH9pvvqYPX3CB3Wue4gF xzgKoDpROkD4mEM8MGJkzPOEzvFF/m2UHGbue73XoSDZOVJ2Ax5U2bbj2OS++aXRKnXk IrvuM9hyKExwTSbAwSnnUyyk68xPlgv+YVSFxW8CMYG/ztBvZCz8rWzhPgk3j1LHBfNO 7MqaHS0j7uAbvb6hE2B7tRNvLbWqpG6pdzMMg7ULSEuTSZ3CbaGhg/jyQl5rcv5rtoXs QsVHjywT3FDVprAMrfmGjX/ZzLRYqw+h3zr1fyiUKdJl7hIULsN/rcT8X/8Af4AfgUTu qO1w== X-Gm-Message-State: AOJu0YyIgXeBbZkKxJ1rD0c/ve2+fLNsMGpJuQLdDQAh7hW2Ann+9GCT GxCA2w9Qu4WHTpDjiKZ6b5C3OxujSPENALUWCaDFM3sTshC/xwlr74W8PT4MQdvwIiDTuCO6QPq R+xMcYRZF3um/f7jaRSICVjEPqaPk26RxDOleazmb096uUQpC51Lk X-Gm-Gg: ASbGncu8JqwIoGTALnJsmA1ddJ0+fAWFp4YuhjuQYc3QjKK0SYdpPXFB5AuiDBpVeo0 v5XSwD3ADUeY7dTRmhc78S/1So4PaNgec95R46cBtREAkjEIuMcFuittg1wUKJ++V+qPo7rCl+W jIP2VhstgG4imYrGhChSAeobyJInnGrg12PxQqbZ8PKkkme47HAbD92edbMC/wQe/7qncVFxSVT ehdIGM4nTT+ZvPOTKnEL0hefT4TNIm8mlnEY7yWKX7CTHdQOc0rw/7q X-Received: by 2002:a05:620a:45a9:b0:7b1:3c0e:b7ea with SMTP id af79cd13be357-7b6bcb74152mr43753385a.45.1733424415311; Thu, 05 Dec 2024 10:46:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWSbLOEyH0ChvRbHZmVKDH2iR96SThkC8Fb/8tIoxKDUmk5c/mNbNGYoNWdjNiWVoYKlJVjQ== X-Received: by 2002:a05:620a:45a9:b0:7b1:3c0e:b7ea with SMTP id af79cd13be357-7b6bcb74152mr43750585a.45.1733424414994; Thu, 05 Dec 2024 10:46:54 -0800 (PST) Received: from [10.195.154.128] ([144.121.20.163]) by smtp.googlemail.com with ESMTPSA id af79cd13be357-7b6b5a5c3casm85880985a.43.2024.12.05.10.46.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2024 10:46:54 -0800 (PST) Message-ID: <9cb123e2-5237-46e7-b6fe-ce8f813cc43c@redhat.com> Date: Thu, 5 Dec 2024 19:46:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 07/13] rust: add bindings for timer To: Zhao Liu , "Michael S . Tsirkin" , Manos Pitsidianakis , Junjie Mao , =?UTF-8?Q?Alex_Benn=C3=A9e?= , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Peter Maydell Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org References: <20241205060714.256270-1-zhao1.liu@intel.com> <20241205060714.256270-8-zhao1.liu@intel.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20241205060714.256270-8-zhao1.liu@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/5/24 07:07, Zhao Liu wrote: > +impl QEMUTimer { > + fn new() -> Self { > + QEMUTimer { > + expire_time: 0, > + timer_list: ::core::ptr::null_mut(), > + cb: None, > + opaque: ::core::ptr::null_mut(), > + next: ::core::ptr::null_mut(), > + attributes: 0, > + scale: 0, > + } > + } Please implement Zeroable instead and make this just Self::ZERO. > + // TODO: Consider how to avoid passing in C style callbacks directly. > + fn timer_new_full( > + timer_list_group: Option<&mut QEMUTimerListGroup>, > + clk_type: QEMUClockType, > + scale: u32, > + attributes: u32, > + opaque: &mut T::Opaque, This gets tricky when you have more than one timer per device. With the right infrastructure we can make this something like fn timer_init_full<'a, 'b: 'a, T, F: 'b Fn(&'b T)>( &'a mut self, timer_list_group: Option<&mut QEMUTimerListGroup>, clk_type: QEMUClockType, scale: u32, attributes: u32, f: &F, opaque: &'b T) { // SAFETY: the opaque outlives the timer unsafe { timer_init_full(...) } } So I guess that's another thing I have to extract and post. :) BTW don't bother with timer_new, only do the non-pointer timer_init. > + pub fn timer_del(&mut self) { > + unsafe { timer_del(self as *mut QEMUTimer) }; > + } > +} Please also add a Drop implementation that calls timer_del. > +pub fn qemu_clock_get_virtual_ns() -> u64 { > + // SAFETY: > + // Valid parameter. > + (unsafe { qemu_clock_get_ns(QEMUClockType::QEMU_CLOCK_VIRTUAL) }) as u64 > +} Maybe something like pub struct Clock { id: QEMUClockType } impl Clock { pub fn get_ns() -> u64 { // SAFETY: cannot be created outside this module, therefore id // is valid (unsafe { qemu_clock_get_ns(self.id) }) as u64 } } pub static CLOCK_VIRTUAL: Clock = Clock { id: QEMUClockType::QEMU_CLOCK_VIRTUAL }; // etc. and then the user can do timer::CLOCK_VIRTUAL::get_ns(). Paolo