From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232
Date: Wed, 23 Jan 2019 09:10:39 -0600 [thread overview]
Message-ID: <9cc018a7-beab-915d-ca4b-561e80c0925a@redhat.com> (raw)
In-Reply-To: <20190123144610.8842-3-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On 1/23/19 8:46 AM, Max Reitz wrote:
> This test creates no such file.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/232 | 1 -
> 1 file changed, 1 deletion(-)
I'd really like it if we could revive Jeff's patches that made ./check
run all tests in their own subdirectory, and then where the framework
could either keep all temporary files or remove the directory, rather
than each test having to track which files it touches.
But that's a bigger task; in the meantime, this patch is fine.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-23 15:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 14:46 [Qemu-devel] [PATCH 0/9] iotests: Fix some issues Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 1/9] iotests: Re-add filename filters Max Reitz
2019-01-29 21:22 ` John Snow
2019-01-23 14:46 ` [Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232 Max Reitz
2019-01-23 15:10 ` Eric Blake [this message]
2019-01-29 21:23 ` John Snow
2019-01-23 14:46 ` [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS Max Reitz
2019-01-29 21:26 ` John Snow
2019-01-30 13:05 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 4/9] iotests: Fix 207 to use QMP filters for qmp_log Max Reitz
2019-01-29 21:31 ` John Snow
2019-01-30 13:16 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 5/9] iotests: Fix 237 for Python 2.x Max Reitz
2019-01-29 21:21 ` John Snow
2019-01-30 13:06 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 6/9] iotests.py: Add is_str() Max Reitz
2019-01-29 21:35 ` John Snow
2019-01-30 13:23 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 7/9] iotests.py: Filter filename in any string value Max Reitz
2019-01-29 21:36 ` John Snow
2019-01-23 14:46 ` [Qemu-devel] [PATCH 8/9] iotests: Filter SSH paths Max Reitz
2019-01-29 21:40 ` John Snow
2019-01-23 14:46 ` [Qemu-devel] [PATCH 9/9] iotests.py: s/_/-/g on keys in qmp_log() Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cc018a7-beab-915d-ca4b-561e80c0925a@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).