From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16E0FC4332F for ; Mon, 12 Dec 2022 14:44:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4k2l-0001vK-Eh; Mon, 12 Dec 2022 09:44:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4k2j-0001rh-1w for qemu-devel@nongnu.org; Mon, 12 Dec 2022 09:44:33 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4k2g-0004ze-GZ for qemu-devel@nongnu.org; Mon, 12 Dec 2022 09:44:32 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BCDchr9029873 for ; Mon, 12 Dec 2022 14:44:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=xP1EqUHylYzA6NKsj61vQfe096rTevlch4yMLHwE+jY=; b=fSSAEh+6YUPivyqQqISJYGwpX81f9kC6CyYc/Lv7HYfs9A8tlhXtARxbz1cZDuRoTFZc HSiQ9RfiyLV7aAxkzE4Q4MYC/oeKbZCe+e3Ip5PSVwo5nf1W5FSPH8eMam3lrCwjUicu XmPv/rbDhGcKmZFJGuycgW+A01EyGAfp6ls2zUjBRS8fOEmIL0gvEZR/nQWtiv7XFwDk llarPUhJcc5cLjRQxHFBoLPs6KVr6msEU2bN4Uet6oSd7qMtaBm/ym+Y+t324xZjaYil cKVtdLJmB/PlOmX+Tmds8slIa+H4SOus7P2qwkQGIrOrRRslcO9l/A9feHr7m8FU/v3+ RA== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3md3sjuk9f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 12 Dec 2022 14:44:29 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BCCeHNc014270 for ; Mon, 12 Dec 2022 14:44:28 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([9.208.130.98]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3mchr6rxc2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 12 Dec 2022 14:44:28 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BCEiQEb61997350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Dec 2022 14:44:27 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A945558063; Mon, 12 Dec 2022 14:44:26 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 60E5058055; Mon, 12 Dec 2022 14:44:26 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 12 Dec 2022 14:44:26 +0000 (GMT) Message-ID: <9cc63b28-6700-59b3-1d4d-b89a4744a09b@linux.ibm.com> Date: Mon, 12 Dec 2022 09:44:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] tpm: add backend for mssim Content-Language: en-US To: jejb@linux.ibm.com, qemu-devel@nongnu.org References: <4780481659602f92fffacac66e7dca41ad2787c4.camel@linux.ibm.com> <4dae1219d816277085fcb82979cf6cded6a1bd6b.camel@linux.ibm.com> From: Stefan Berger In-Reply-To: <4dae1219d816277085fcb82979cf6cded6a1bd6b.camel@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: uNz2q3zEIYUduUbTnRBjn8Tyalq7d-X3 X-Proofpoint-ORIG-GUID: uNz2q3zEIYUduUbTnRBjn8Tyalq7d-X3 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-12_02,2022-12-12_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 malwarescore=0 mlxscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=801 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212120133 Received-SPF: pass client-ip=148.163.158.5; envelope-from=stefanb@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/12/22 09:32, James Bottomley wrote: > On Mon, 2022-12-12 at 09:27 -0500, Stefan Berger wrote: >> >> >> On 12/12/22 08:59, James Bottomley wrote: >>> On Mon, 2022-12-12 at 08:43 -0500, Stefan Berger wrote: >>>> >>>> >>>> On 12/10/22 12:10, James Bottomley wrote: >>>>> The Microsoft Simulator (mssim) is the reference emulation >>>>> platform >>>>> for the TCG TPM 2.0 specification. >>>>> >>>>> https://github.com/Microsoft/ms-tpm-20-ref.git >>>>> >>>>> It exports a fairly simple network socket baset protocol on two >>>> >>>> baset -> based. >>>> >>>>> sockets, one for command (default 2321) and one for control >>>>> (default 2322).  This patch adds a simple backend that can >>>>> speak the mssim protocol over the network.  It also allows the >>>>> host, and two ports to be specified on the qemu command line. >>>>> The benefits are twofold: firstly it gives us a backend that >>>>> actually speaks a standard TPM emulation protocol instead of >>>>> the linux specific TPM driver format of the current emulated >>>>> TPM backend and secondly, using the microsoft protocol, the end >>>>> point of the emulator can be anywhere on the network, >>>>> facilitating the cloud use case where a central TPM ervice can >>>>> be used over a control network. >>>>> >>>>> The implementation does basic control commands like power >>>>> off/on, but doesn't implement cancellation or startup.  The >>>>> former because cancellation is pretty much useless on a fast >>>>> operating TPM emulator and the latter because this emulator is >>>>> designed to be used with OVMF which itself does TPM startup and >>>>> I wanted to validate that. >>>> >>>> How did you implement VM suspend/resume and snapshotting support? >>> >>> TPM2 doesn't need to.  The mssim follows the reference model which >> >> >> You mean TPM2 doesn't need to resume at the point where the VM >> resumes (I am not talking about ACPI resume but virsh save/restore) >> after for example a host reboot? >> What does this have to do with the mssim reference model and >> TPM2_Shutdown protocol? > > Running S3 suspend/resume before doing VM save/restore could fix a lot > of issue with passthrough PCI and when QEMU gets around to doing that a > TPM following the standard model should just work. It's useful to have > a driver supporting this work. Did you test it with virsh save / restore with the mssim TPM? Does it work? Does it work if you reboot the host in between? Stefan > > James >