qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, asias@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 7/8] vhost: set started flag while start is in progress
Date: Wed, 26 Dec 2012 12:52:42 +0200	[thread overview]
Message-ID: <9cce4f7971df53927ff787635a1b909f79507af6.1356519046.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1356519045.git.mst@redhat.com>

This makes it possible to use started flag for sanity checking
of callbacks that happen during start/stop.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/vhost.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/vhost.c b/hw/vhost.c
index b6d73ca..4fa5007 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -873,6 +873,9 @@ void vhost_dev_disable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
 int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
 {
     int i, r;
+
+    hdev->started = true;
+
     if (!vdev->binding->set_guest_notifiers) {
         fprintf(stderr, "binding does not support guest notifiers\n");
         r = -ENOSYS;
@@ -918,8 +921,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
         }
     }
 
-    hdev->started = true;
-
     return 0;
 fail_log:
 fail_vq:
@@ -934,6 +935,8 @@ fail_features:
     vdev->binding->set_guest_notifiers(vdev->binding_opaque, hdev->nvqs, false);
 fail_notifiers:
 fail:
+
+    hdev->started = false;
     return r;
 }
 
-- 
MST

      parent reply	other threads:[~2012-12-26 10:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-26 10:52 [Qemu-devel] [PATCH 0/8] virtio-pci: msix masking optimizations Michael S. Tsirkin
2012-12-26 10:52 ` [Qemu-devel] [PATCH 1/8] virtio: don't waste irqfds on control vqs Michael S. Tsirkin
2013-01-03 11:51   ` Stefan Hajnoczi
2012-12-26 10:52 ` [Qemu-devel] [PATCH 2/8] msix: add api to access msix message Michael S. Tsirkin
2012-12-26 10:52 ` [Qemu-devel] [PATCH 4/8] virtio-pci: cache msix messages Michael S. Tsirkin
2012-12-26 10:52 ` [Qemu-devel] [PATCH 3/8] kvm: add stub for update msi route Michael S. Tsirkin
2012-12-26 10:52 ` [Qemu-devel] [PATCH 5/8] virtio: backend virtqueue notifier masking Michael S. Tsirkin
2012-12-26 10:52 ` [Qemu-devel] [PATCH 8/8] vhost: backend masking support Michael S. Tsirkin
2012-12-26 10:52 ` [Qemu-devel] [PATCH 6/8] virtio-net: set/clear vhost_started in reverse order Michael S. Tsirkin
2012-12-26 10:52 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cce4f7971df53927ff787635a1b909f79507af6.1356519046.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=asias@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).