From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [RFC PATCH 2/2] bulk: Replace !CONFIG_USER_ONLY -> CONFIG_SOFTMMU
Date: Sat, 3 Jun 2023 01:14:32 +0200 [thread overview]
Message-ID: <9cd4b1cf-f8f9-2bb9-0546-872be0f25e86@linaro.org> (raw)
In-Reply-To: <20230602225811.60152-3-philmd@linaro.org>
On 3/6/23 00:58, Philippe Mathieu-Daudé wrote:
> CONFIG_SOFTMMU is the opposite of CONFIG_USER_ONLY.
> Now that CONFIG_SOFTMMU isn't poisoined anymore,
> replace !CONFIG_USER_ONLY negation by the positive
> form which is clearer when reviewing code.
>
> Change mostly done mechanically using:
>
> $ sed -i -e 's/ifndef CONFIG_USER_ONLY/ifdef CONFIG_SOFTMMU/' \
> -e 's/!defined(CONFIG_USER_ONLY)/defined(CONFIG_SOFTMMU)/' \
> $(git grep -l CONFIG_USER_ONLY)
>
> and adapting comments manually.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
*Sigh* I was not building in the correct build directory,
now I realize this patch is crap because the CONFIG_SOFTMMU
definitions is not propagated on all objects.
Please disregard...
prev parent reply other threads:[~2023-06-02 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:58 [RFC PATCH 0/2] bulk: Replace !CONFIG_SOFTMMU and !CONFIG_USER_ONLY Philippe Mathieu-Daudé
2023-06-02 22:58 ` [RFC PATCH 1/2] bulk: Replace !CONFIG_SOFTMMU -> CONFIG_USER_ONLY Philippe Mathieu-Daudé
2023-06-03 3:49 ` Richard Henderson
2023-06-05 20:29 ` Philippe Mathieu-Daudé
2023-06-05 21:39 ` Richard Henderson
2023-06-02 22:58 ` [RFC PATCH 2/2] bulk: Replace !CONFIG_USER_ONLY -> CONFIG_SOFTMMU Philippe Mathieu-Daudé
2023-06-02 22:59 ` Philippe Mathieu-Daudé
2023-06-02 23:14 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd4b1cf-f8f9-2bb9-0546-872be0f25e86@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).