From: Paolo Bonzini <pbonzini@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [PATCH 4/8] meson: drop the .fa library suffix
Date: Wed, 23 Feb 2022 10:07:59 +0100 [thread overview]
Message-ID: <9cdd93f2-af65-ba5c-c5df-8f9e4d42eeaf@redhat.com> (raw)
In-Reply-To: <20220222194008.610377-5-marcandre.lureau@redhat.com>
On 2/22/22 20:40, marcandre.lureau@redhat.com wrote:
>
> The .fa suffix was a temporary hack introduced in commit
> 1f0a1d8a51 ("build-sys hack: link with whole .fa archives") when the
> build system was mixed between meson & makefiles. It is no longer
> needed.
It is still needed to separate internal and system archives, otherwise
the oss-fuzz build fails. Meson adds a --start-group/--end-group pair
around all libraries, and the fork-fuzz.ld linker script should be
outside it. If the libraries are named .a, the --start-group is placed
much earlier.
This is of course a very ugly workaround; Meson should just use the
objects instead of the archives when link_whole is used with an internal
convenience archive.
Paolo
next prev parent reply other threads:[~2022-02-23 9:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 19:40 [PATCH 0/8] Misc build fixes and cleanups marcandre.lureau
2022-02-22 19:40 ` [PATCH 1/8] meson: fix generic location of vss headers marcandre.lureau
2022-02-22 19:40 ` [PATCH 2/8] qga/vss-win32: check old VSS SDK headers marcandre.lureau
2022-02-22 19:40 ` [PATCH 3/8] qga/vss: update informative message about MinGW marcandre.lureau
2022-02-22 19:40 ` [PATCH 4/8] meson: drop the .fa library suffix marcandre.lureau
2022-02-23 9:07 ` Paolo Bonzini [this message]
2022-02-23 9:14 ` Marc-André Lureau
2022-02-24 14:01 ` Paolo Bonzini
2022-02-22 19:40 ` [PATCH 5/8] meson: use chardev_ss dependencies marcandre.lureau
2022-02-22 19:40 ` [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/ marcandre.lureau
2022-02-24 17:04 ` Marc-André Lureau
2022-02-26 7:38 ` Paolo Bonzini
2022-02-28 7:53 ` Marc-André Lureau
2022-02-28 9:13 ` Daniel P. Berrangé
2022-02-28 11:07 ` Peter Maydell
2022-02-28 11:14 ` Daniel P. Berrangé
2022-02-22 19:40 ` [PATCH 7/8] Drop qemu_foo() socket API wrapper marcandre.lureau
2022-02-22 21:26 ` Philippe Mathieu-Daudé
2022-02-24 15:53 ` Eric Blake
2022-02-22 19:40 ` [PATCH 8/8] Replace GCC_FMT_ATTR with G_GNUC_PRINTF marcandre.lureau
2022-02-24 14:03 ` [PATCH 0/8] Misc build fixes and cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdd93f2-af65-ba5c-c5df-8f9e4d42eeaf@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).