From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JofLx-0002yW-1n
	for qemu-devel@nongnu.org; Wed, 23 Apr 2008 09:49:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JofLt-0002uf-1B
	for qemu-devel@nongnu.org; Wed, 23 Apr 2008 09:49:40 -0400
Received: from [199.232.76.173] (port=48096 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JofLs-0002uW-Oo
	for qemu-devel@nongnu.org; Wed, 23 Apr 2008 09:49:36 -0400
Received: from el-out-1112.google.com ([209.85.162.183])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <aquynh@gmail.com>) id 1JofLr-0001BV-Av
	for qemu-devel@nongnu.org; Wed, 23 Apr 2008 09:49:35 -0400
Received: by el-out-1112.google.com with SMTP id v27so950451ele.12
	for <qemu-devel@nongnu.org>; Wed, 23 Apr 2008 06:49:34 -0700 (PDT)
Message-ID: <9cde8bff0804230649q6a7825cdk69cc0f8ef6117994@mail.gmail.com>
Date: Wed, 23 Apr 2008 22:49:34 +0900
From: "Nguyen Anh Quynh" <aquynh@gmail.com>
In-Reply-To: <480E10E5.1000401@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <9cde8bff0804202032k6bd44ac6td913c05410e6284@mail.gmail.com>
	<9cde8bff0804202033p68524e8ag8503b5ba8ab89100@mail.gmail.com>
	<9cde8bff0804202036w62cc553fhca142ec2731a3a8e@mail.gmail.com>
	<9cde8bff0804220207g3fd39012rc8f5480fae34aff2@mail.gmail.com>
	<480E10E5.1000401@zytor.com>
Subject: [Qemu-devel] Re: [RFC] linuxboot Option ROM for Linux kernel booting
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: kvm-devel@lists.sourceforge.net, Alexander Graf <alex@csgraf.de>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

On 4/23/08, H. Peter Anvin <hpa@zytor.com> wrote:
> Nguyen Anh Quynh wrote:
>
> > Hi,
> >
> > I am thinking about comibing this ROM with the extboot. Both two ROM
> > are about "booting", so I think that is reasonable. So we will have
> > only 1 ROM that supports both external boot and Linux boot.
> >
> > Is that desirable or not?
> >
> >
>
>  Does it make the code simpler and easier to understand?  If not, then I would say no.


Actually no. I must say that it looks ugly to me.

The fact is that linuxboot ROM and extboot ROM are about different
things, and they only share a bit in that they both intercept int 19.

I very much like the the Unix principal, that is "Does one thing, and
does it well", so I prefer to have 2 independent ROM: one to boot
Linux, and one to do external boot. I see no problem that we have more
than one ROM, and these two can be independently loaded into the
memory.

So I think I agree with Peter here.

Thanks,
Q