From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52CBC433E0 for ; Tue, 9 Mar 2021 11:06:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A87465252 for ; Tue, 9 Mar 2021 11:06:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A87465252 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJaC0-0000MT-0C for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 06:06:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJa11-0003nq-2o for qemu-devel@nongnu.org; Tue, 09 Mar 2021 05:55:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJa0t-0002mG-Fg for qemu-devel@nongnu.org; Tue, 09 Mar 2021 05:55:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615287293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GUkVWtO4wU2tLsNxibFoSMTJ0Z8k34HxCnX16WFh7XY=; b=V4q6wplz6uqECPRbqjFmyiAhg99R7i3fKIoakc5Dww/M74X1QfF72LG2oChocAFLJQLF9v WEqi87f1l1WnQC7FD/OG/6EBeKcGPyPYdhU0Q9cWsiXgu3TaJBHbSZJdbEhFVMI/CbD0ph rbBjsahftyYzBqqwJzAl9yppfM2Mm2k= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-chSw4_o6OaOLEXCpBZpbuQ-1; Tue, 09 Mar 2021 05:54:52 -0500 X-MC-Unique: chSw4_o6OaOLEXCpBZpbuQ-1 Received: by mail-wm1-f72.google.com with SMTP id n25so979294wmk.1 for ; Tue, 09 Mar 2021 02:54:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GUkVWtO4wU2tLsNxibFoSMTJ0Z8k34HxCnX16WFh7XY=; b=sfpa1wzvWrKM2D8Ij9AsBgTZveKR9/crNPN/k+ikGXuyeeQqT8qdg8kLx7PeiRkFk3 aYFm6MNZCGnh1a2aN7m9ycKszDN+laPMIxsS9f8TErHn+5BUiDYboF+stu7mslTjyGIG woKzkWwZxAOa3SJZTnR7lbrGmYXXdsZhZcP9WIcTvLTcLJ7PpESGdytHgjNx6LtGrwLK +aQp9aBHwxJO+WTbePLVLg8I7HI1zTLnNbsyjaQh+og3KN375buNm/CgYbJDIqZl2DDE 2VPV2NgTYL7Xu+R8WNRxD8tdlM1tbWh4RlHx5sAMpgkfJYVcrV4fFe41U5MFhjCHirb/ E9WQ== X-Gm-Message-State: AOAM532rRGgj1IhjSLS8ZC2LqeSDA5Gbvh5eFLXPNt+duMjsgKTbr7nB 4ot/3iiycVV1mahR06z/1wdUSyaYyzJO3M2GRyUpezDdtt/AC34yL8O+4WgYpCLuHanLzZZEzTa gMfNhxBGUCfuHZr8v5nikjDuQookq/lc10IkK6GBht82a8eIZ/So1c7vB9EHqhLkl X-Received: by 2002:a7b:cdf7:: with SMTP id p23mr3393823wmj.26.1615287291002; Tue, 09 Mar 2021 02:54:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKrD7YAsHYcqGiGcOLd2FHJQNXIlNNEr6Fl15OcoyqC6ea0GrqTx43YuYCfUQhOTjA2XvBoQ== X-Received: by 2002:a7b:cdf7:: with SMTP id p23mr3393800wmj.26.1615287290762; Tue, 09 Mar 2021 02:54:50 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id b186sm3456418wmc.44.2021.03.09.02.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 02:54:50 -0800 (PST) Subject: Re: [RFC PATCH v2] meson: Only generate trace files for selected targets To: Paolo Bonzini , Claudio Fontana , Stefan Hajnoczi References: <20210224213515.3331631-1-philmd@redhat.com> <7ff2c1ed-e6ad-4a6f-3552-be5ba90960d7@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <9cf0f38a-3b9c-6f18-e5f2-9be31c708312@redhat.com> Date: Tue, 9 Mar 2021 11:54:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <7ff2c1ed-e6ad-4a6f-3552-be5ba90960d7@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/9/21 11:26 AM, Paolo Bonzini wrote: > On 09/03/21 09:41, Claudio Fontana wrote: >> In any case, I agree that just recursing all directories in target/ >> looking for trace.h / traceevents files could be better. > > Using the directory structure to find source files is a bad idea because > you don't notice that you haven't "git add"ed a file until it's too late > (typically the maintainer notices it for you...). > > We do it for default-configs/targets, but that's an exception and I'd > rather not extend it more. > > In fact, Philippe, perhaps you can add the extra tracedirs for hw/ and > target/ to the default-config/targets/*.mak file? Hmm interesting idea... I'll have a look, thanks!