From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Eric Blake" <eblake@redhat.com>,
"Cameron Esfahani" <dirty@apple.com>,
"Mads Ynddal" <mads@ynddal.dk>,
"Phil Dennis-Jordan" <phil@philjordan.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Roman Bolshakov" <rbolshakov@ddn.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH-for-10.1 v5 1/7] Revert "accel/tcg: Unregister the RCU before exiting RR thread"
Date: Tue, 15 Jul 2025 06:38:39 -0600 [thread overview]
Message-ID: <9cf478e2-1607-4cb7-9769-70d923a672b3@linaro.org> (raw)
In-Reply-To: <20250715104015.72663-2-philmd@linaro.org>
On 7/15/25 04:40, Philippe Mathieu-Daudé wrote:
> This reverts commit bc93332fe460211c2d2f4ff50e1a0e030c7b5159,
> which was merged prematurely, re-introducing Coverity CID 1547782
> (unreachable code).
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> accel/tcg/tcg-accel-ops-rr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c
> index a578698d071..6eec5c9eee9 100644
> --- a/accel/tcg/tcg-accel-ops-rr.c
> +++ b/accel/tcg/tcg-accel-ops-rr.c
> @@ -302,8 +302,6 @@ static void *rr_cpu_thread_fn(void *arg)
> rr_deal_with_unplugged_cpus();
> }
>
> - rcu_unregister_thread();
> -
> g_assert_not_reached();
> }
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-07-15 13:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 10:40 [PATCH-for-10.1 v5 0/7] accel/system: Add 'info accel' on human monitor Philippe Mathieu-Daudé
2025-07-15 10:40 ` [PATCH-for-10.1 v5 1/7] Revert "accel/tcg: Unregister the RCU before exiting RR thread" Philippe Mathieu-Daudé
2025-07-15 11:19 ` Manos Pitsidianakis
2025-07-15 12:38 ` Richard Henderson [this message]
2025-07-15 10:40 ` [PATCH-for-10.1 v5 2/7] accel/tcg: Extract statistic related code to tcg-stats.c Philippe Mathieu-Daudé
2025-07-15 12:44 ` Richard Henderson
2025-07-15 13:18 ` Richard Henderson
2025-07-15 10:40 ` [PATCH-for-10.1 v5 3/7] accel/system: Introduce @x-accel-stats QMP command Philippe Mathieu-Daudé
2025-07-15 10:40 ` [PATCH-for-10.1 v5 4/7] accel/system: Add 'info accel' on human monitor Philippe Mathieu-Daudé
2025-07-15 10:40 ` [PATCH-for-10.1 v5 5/7] accel/tcg: Propagate AccelState to tcg_dump_stats() Philippe Mathieu-Daudé
2025-07-15 11:19 ` Manos Pitsidianakis
2025-07-15 13:20 ` Richard Henderson
2025-07-15 10:40 ` [PATCH-for-10.1 v5 6/7] accel/tcg: Implement get_[vcpu]_stats() Philippe Mathieu-Daudé
2025-07-15 10:42 ` Philippe Mathieu-Daudé
2025-07-15 12:48 ` Richard Henderson
2025-07-15 13:06 ` Philippe Mathieu-Daudé
2025-07-15 13:18 ` Richard Henderson
2025-07-15 13:26 ` Philippe Mathieu-Daudé
2025-07-15 10:40 ` [PATCH-for-10.1 v5 7/7] accel/hvf: Implement get_vcpu_stats() Philippe Mathieu-Daudé
2025-07-15 10:57 ` Mads Ynddal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cf478e2-1607-4cb7-9769-70d923a672b3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=dirty@apple.com \
--cc=eblake@redhat.com \
--cc=mads@ynddal.dk \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).